Update Eventing Sources API to v1

[dsimansk]

Description

Follow-up on recent v1alpha1 removal from Eventing main.
knative/eventing#5318

Changes

• Update to APIServerSource, ContainerSource, PingSource & SinkBinding API to sources/v1

/cc @knative/client-reviewers

[knative-prow-robot]

@dsimansk: 0 warnings.

In response to this:

Description

Follow-up on recent v1alpha1 removal from Eventing main.
knative/eventing#5318

Changes

• Update to APIServerSource, ContainerSource, PingSource & SinkBinding API to sources/v1

/cc @knative/client-reviewers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

There's one open question though. PingSource was promoted to v1 API just now, that's why integration tests are failing currently. For that reason we can't use PingSource v1 on 0.22 as well, breaking the backward compatibility, therefore we need to keep PingSource at v1beta2 for now. (applying the common client API policy keeping the lowest version until available)

@rhuss @maximilien any objections to the above? I'm mainly asking due to implications for 1.0 release etc.

[rhuss]

Yeah, let's stay with PingSource v1beta2.

If Eventing goes to Knative 1.0 with v1beta2, too, I don't see any problems to use this for a 1.0 client.

[rhuss]

@lionelvillard Are there any plans for Evention 1.0 to remove PingSource v1beta2, too ?

[lionelvillard]

@lionelvillard Are there any plans for Evention 1.0 to remove PingSource v1beta2, too ?

We have to keep v1beta2 for at least of couple of releases.

[dsimansk]

/retest

[rhuss]

Serving v1beta2 ?

[dsimansk]

🙈

[rhuss]

Looks good, however while cross checking it looks like that there has been a gotcha when reverting from v1 back to v1beta2 for the ping source (see comment inline). Not sure if other parts are affected, too.

[rhuss]

/retest

/lgtm
/approve

[maximilien]

/ok-to-test
/lgtm

[rhuss]

Looks like that the test indeed captured a valid issue:

source_list_test.go:85: assertion failed: 
        Actual output: NAME              TYPE         RESOURCE                          SINK   READY
        testpingsource0   PingSource   pingsources.sources.knative.dev          True
        
        Missing strings: ksvc:testsvc0

i.e. there is no output of the connected sink.

[dsimansk]

Looks like that the test indeed captured a valid issue:

source_list_test.go:85: assertion failed: 
        Actual output: NAME              TYPE         RESOURCE                          SINK   READY
        testpingsource0   PingSource   pingsources.sources.knative.dev          True
        
        Missing strings: ksvc:testsvc0

i.e. there is no output of the connected sink.

Well, this one was pretty hard to find actually. 😓
The error is caused by failed unstructured conversion due to knative/eventing@7c0b477.

Update: adding more details. The above change/fix was backported to Eventing patch release 0.22.1. Therefore the next client release will fully work with v1beta2 PingSource and Eventing 0.22.1 combination.
The only issue is with 0.22.0 and kn source list - general source, list that uses Unstructured to list all present sources, doesn't display sink reference (or further details with -o yaml, etc.), but kn source ping describe and everything else related to PingSource CRUD operations is OK.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/types.go	55.1%	57.8%	2.7
pkg/sources/common.go	Do not exist	100.0%
pkg/sources/v1/apiserver_client.go	Do not exist	90.0%
pkg/sources/v1/apiserver_client_mock.go	Do not exist	77.3%
pkg/sources/v1/binding_client.go	Do not exist	84.7%
pkg/sources/v1/binding_client_mock.go	Do not exist	90.9%
pkg/sources/v1/client.go	Do not exist	100.0%
pkg/sources/v1/container_client.go	Do not exist	89.5%
pkg/sources/v1/container_client_mock.go	Do not exist	90.9%
pkg/sources/v1beta2/client.go	Do not exist	100.0%
pkg/sources/v1beta2/ping_client.go	Do not exist	90.0%
pkg/sources/v1beta2/ping_client_mock.go	Do not exist	77.3%

[rhuss]

The only issue with 0.22.0 ...

That's fine I would say, as we can always say that's an issue with the backend and the fix is, to update the eventing backend to 0.22.1

[rhuss]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment