Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary help message #1158

Merged
merged 1 commit into from
Dec 1, 2020
Merged

remove unnecessary help message #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
|===
| | Description | PR

| 🐣
| Removes unnecessary help message introduced for machine-readable outputs for command 'kn source binding describe'
| https://github.com/knative/client/pull/1158[#1158]

| 🐣
| Removes unnecessary help message introduced for machine-readable outputs for commands which does not have -o url flag
| https://github.com/knative/client/pull/1152[#1152]
Expand All @@ -33,7 +37,7 @@
| Add machine readable output (-o flag) to kn source binding describe
| https://github.com/knative/client/pull/1148[#1148]

| 🐛
| 🎁
| Add machine readable output (-o flag) to kn source apiserver describe
| https://github.com/knative/client/pull/1146[#1146]

Expand Down
2 changes: 0 additions & 2 deletions pkg/kn/commands/source/binding/describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"errors"
"fmt"
"sort"
"strings"

"github.com/spf13/cobra"
"k8s.io/cli-runtime/pkg/genericclioptions"
Expand Down Expand Up @@ -99,7 +98,6 @@ func NewBindingDescribeCommand(p *commands.KnParams) *cobra.Command {
commands.AddNamespaceFlags(flags, false)
flags.BoolP("verbose", "v", false, "More output.")
machineReadablePrintFlags.AddFlags(command)
command.Flag("output").Usage = fmt.Sprintf("Output format. One of: %s.", strings.Join(machineReadablePrintFlags.AllowedFormats(), "|"))
return command
}

Expand Down