Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add machine readable output (-o flag) to kn source binding describe #1148

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Add machine readable output (-o flag) to kn source binding describe #1148

merged 1 commit into from
Nov 27, 2020

Conversation

Kaustubh-pande
Copy link
Contributor

Description

Changes

Add machine readable output (-o flag) to kn source binding describe

Reference

Fixes #1097

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 26, 2020
knative-prow-robot
knative-prow-robot reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kaustubh-pande: 0 warnings.

In response to this:

Description

Changes

Add machine readable output (-o flag) to kn source binding describe

Reference

Fixes #1097

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 26, 2020
@knative-prow-robot
Copy link
Contributor

Hi @Kaustubh-pande. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2020
@Kaustubh-pande
Copy link
Contributor Author

/assign @navidshaikh

arghya88
arghya88 reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@arghya88 arghya88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Can you update the CHANGELOG as well

@dsimansk
Copy link
Contributor

Thanks!
As mentioned above pls update the changelog. And linter is complaining about whitespace char on a empty line.
/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2020
navidshaikh
navidshaikh approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit in the example, rest lgtm!

pkg/kn/commands/source/binding/describe.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/source/binding/describe.go 90.9% 90.5% -0.4
pkg/sources/v1alpha2/binding_client.go 85.4% 84.7% -0.7

navidshaikh
navidshaikh reviewed Nov 27, 2020
View reviewed changes
pkg/kn/commands/source/binding/describe.go

return cmd
machineReadablePrintFlags.AddFlags(command)
command.Flag("output").Usage = fmt.Sprintf("Output format. One of: %s.", strings.Join(machineReadablePrintFlags.AllowedFormats(), "|"))
Copy link
Collaborator

@navidshaikh navidshaikh Nov 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is only needed when we're adding any other custom output format (like -ourl) to be able to append that custom format to help message, otherwise this line can be omitted and the default help message is sufficient
@arghya88 also applies to all the recent -o PRs landed without -ourl

navidshaikh
navidshaikh approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

CHANGELOG.adoc
| Add machine readable output (-o flag) to kn source binding describe
| https://github.com/knative/client/pull/1148[#1148]

| 🐛
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 🐛
| 🎁

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase against latest master should resolve this

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaustubh-pande, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4554c7a into knative:master Nov 27, 2020
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 21, 2022
@dsimansk
[release-v1.5] Add plugins: event, kafka, workflow (knative#1148)
207714a 
* [release-v1.5] Add plugins: event, kafka, workflow

* Update vendor dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arghya88 arghya88 arghya88 left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add machine readable output (-o flag) to kn source binding describe
6 participants
@Kaustubh-pande @knative-prow-robot @dsimansk @knative-metrics-robot @navidshaikh @arghya88