Add machine readable output for trigger

[arghya88]

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

*Add machine readable output (-o flag) to kn trigger describe

Reference

Fixes #1095

/lint

[knative-prow-robot]

@arghya88: 0 warnings.

In response to this:

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

*Add machine readable output (-o flag) to kn trigger describe

Reference

Fixes #1095

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arghya88]

@navidshaikh any idea why the test for -o yaml is failing with error

describe_test.go:91: assertion failed: error is not nil: missing apiVersion or kind; try GetObjectKind().SetGroupVersionKind() if you know the type

[navidshaikh]

@navidshaikh any idea why the test for -o yaml is failing with error

@arghya88 : The genericclioptions util we use to enable the machine readable output, requires GroupVersionKind set on the object.

You need to update GroupVersionKind of the object you GET via knEventingClient.

For example: here its done for the list object of trigger and each individual items in the list. For GET call you should update GVK for the received object in this method.

here is another example of setting GVK for service object we GET

client/pkg/serving/v1/client.go

Line 193 in 1012890

err = updateServingGvk(service)

[navidshaikh]

Please run ./hack/build.sh and commit

📖 Docs ERROR: Modified files found:  M docs/cmd/kn_trigger_describe.md ERROR: Diff diff --git a/docs/cmd/kn_trigger_describe.md b/docs/cmd/kn_trigger_describe.md index 3884b35b..bdc194a7 100644 --- a/docs/cmd/kn_trigger_describe.md +++ b/docs/cmd/kn_trigger_describe.md @@ -19,9 +19,6 @@ kn trigger describe NAME      # Describe a trigger 'my-trigger' in YAML format    kn trigger describe my-trigger -o yaml - -  # Print only trigger URL -  kn trigger describe my-trigger -o url  ```    ### Options ERROR: /home/prow/go/src/knative.dev/client is out of date. Please run ./hack/build.sh -c and commit.
--

[arghya88]

@navidshaikh tests are passing now.PTAL

[arghya88]

/assign @navidshaikh

[navidshaikh]

lgtm, lets fix the typo in CHANGELOG and this should be good to go.

[arghya88]

@navidshaikh Changes done.PTAL

[navidshaikh]

@arghya88 : The CI failure needs a fix in eventing nightly setup, see knative/hack#24 I will retest once its merged/fixed. Meanwhile can you please fix the CHANGELOG as suggested below?

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/eventing/v1beta1/client.go	86.8%	86.2%	-0.6
pkg/kn/commands/trigger/describe.go	82.5%	83.3%	0.8

[navidshaikh]

/retest
/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghya88, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment