Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds --scale range option #1114

Merged
merged 2 commits into from
Nov 24, 2020
Merged

adds --scale range option #1114

merged 2 commits into from
Nov 24, 2020

Conversation

mpetason
Copy link
Contributor

Description

Fixes #822

Changes

  • adds --scale range option, #..#

Reference

Fixes #822

Replaces previous PR where I had issues with a rebase - #1070
Replaces previous PR where I had issues with a rebase - #986

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/configuration_edit_flags.go 84.8% 85.2% 0.4

@navidshaikh navidshaikh added this to the v0.20.0 milestone Nov 12, 2020
@mpetason
Copy link
Contributor Author

@maximilien

@navidshaikh navidshaikh removed this from the v0.20.0 milestone Nov 17, 2020
@rhuss
Copy link
Contributor

rhuss commented Nov 17, 2020

@mpetason Thanks a lot for all your work. Let's get that landed, I will give a review this week so that we finally be able to merge it. Thanks also for your patience.

Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, mpetason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpetason
Copy link
Contributor Author

/test pull-knative-client-integration-tests

@mpetason
Copy link
Contributor Author

It doesn't look like the failing test is associated with my changes. I'll try running it again on Monday.

@mpetason
Copy link
Contributor Author

/test pull-knative-client-integration-tests

@navidshaikh
Copy link
Collaborator

/retest

@knative-prow-robot knative-prow-robot merged commit ed4fa06 into knative:master Nov 24, 2020
if err != nil {
return err
}
} else {
return fmt.Errorf("Scale must be of the format x..y or x")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return fmt.Errorf("Scale must be of the format x..y or x")
return fmt.Errorf("scale must be of the format x..y or x")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error messages should begin with lower case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make this edit and create a new PR, or commit suggestion? Not sure how it works after a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support --scale
6 participants