chore: Remove deprecated requests/limits flags #1110
Conversation
There was a problem hiding this comment.
@dsimansk: 0 warnings.
In response to this:
Description
This PR removes
--requests-cpu,--requests-memory,--limits-cpu,--limits-memorythat should be deprecated already per code comment:// TODO: Flag marked deprecated in release v0.15.0, remove in release v0.18.0@navidshaikh @rhuss @maximilien @daisy-ycguo @itsmurugappan
If there's any reason or support concern that those flags might be still used/useful, please bring it up.Changes
- Remove
--requests-cpu,--requests-memory,--limits-cpu,--limits-memoryReference
Fixes N/A
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/L
|
/milestone v0.19.0 |
|
@dsimansk: You must be a member of the knative/knative-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
/approve
lgtm
thanks @dsimansk !
please add CHANGELOG entry
knative-prow-robot
added
the
approved
|
/lgtm lets get the CHANGELOG added with the v0.19 prep cc: @rhuss |
|
@navidshaikh ups, I've added changelog already. |
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Kaustubh pande <[email protected]>
Description
This PR removes
--requests-cpu,--requests-memory,--limits-cpu,--limits-memorythat should be deprecated already per code comment:@navidshaikh @rhuss @maximilien @daisy-ycguo @itsmurugappan
If there's any reason or support concern that those flags might be still used/useful, please bring it up.
Changes
--requests-cpu,--requests-memory,--limits-cpu,--limits-memoryReference
Fixes N/A