Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithLabel list filter to serving client lib #1054

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Add WithLabel list filter to serving client lib #1054

merged 3 commits into from
Oct 9, 2020

Conversation

zroubalik
Copy link
Contributor

Signed-off-by: Zbynek Roubalik [email protected]

Description

Adding WithLabel list filter to serving client lib, which is missing currently. This allows to filter lists by labels.

Reference

Fixes #1053

/lint

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2020
knative-prow-robot
knative-prow-robot reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zroubalik: 1 warning.

In response to this:

Signed-off-by: Zbynek Roubalik [email protected]

Description

Adding WithLabel list filter to serving client lib, which is missing currently. This allows to filter lists by labels.

Reference

Fixes #1053

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/serving/v1/client.go Outdated Show resolved Hide resolved
@knative-prow-robot
Copy link
Contributor

Welcome @zroubalik! It looks like this is your first PR to knative/client 🎉

@knative-prow-robot
Copy link
Contributor

Hi @zroubalik. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2020
@zroubalik zroubalik mentioned this pull request Oct 8, 2020
Closed
navidshaikh
navidshaikh approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2020
rhuss
rhuss requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Looks good, but could you please also add a test to client_test_mock.go and client_test.go ?

Also an entry in CHANGELOG.adoc would be cool

maximilien
maximilien suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributions. Any way to add tests and show how to use this?

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2020
@zroubalik
Copy link
Contributor Author

I have added tests. Let me know if I should add anything else.

navidshaikh
navidshaikh approved these changes Oct 9, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zroubalik ! can you please finalize the PR with a changelog entry in CHANGELOG.adoc ?

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
Zbynek Roubalik added 3 commits October 9, 2020 12:57
add WithLabel list filter
394823b 
Signed-off-by: Zbynek Roubalik <[email protected]>
adding tests
462bb5b 
Signed-off-by: Zbynek Roubalik <[email protected]>
update changelog
ecb559e 
Signed-off-by: Zbynek Roubalik <[email protected]>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@zroubalik
Copy link
Contributor Author

@navidshaikh Changelog updated, let me know if you need anything else, thanks!

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/serving/v1/client.go 66.5% 66.8% 0.4

@zroubalik
Copy link
Contributor Author

/retest

navidshaikh
navidshaikh approved these changes Oct 9, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks @zroubalik for contribution, keep them coming! ;-)

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4ebd7ed into knative:master Oct 9, 2020
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Oct 9, 2020
@zroubalik @navidshaikh
Add WithLabel list filter to serving client lib (knative#1054)
fa4f4c3 
* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>
@navidshaikh navidshaikh mentioned this pull request Oct 12, 2020
Merged
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Oct 12, 2020
@zroubalik @navidshaikh
Add WithLabel list filter to serving client lib (knative#1054)
28d195b 
* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>
@navidshaikh navidshaikh mentioned this pull request Oct 12, 2020
Merged
@navidshaikh navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Oct 12, 2020
knative-prow-robot pushed a commit that referenced this pull request Oct 12, 2020
@navidshaikh @rhuss @zroubalik
[release-0.17] Backport #1052 and #1054 (#1058)
2d1944d 
* Fix for test flake when sync waiting and an intermediate error occurs (#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added

* Add WithLabel list filter to serving client lib (#1054)

* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>

* Update CHANGELOG

Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request Oct 12, 2020
@navidshaikh @rhuss @zroubalik
[release-0.18] Backport #1052 and #1054 (#1059)
b6fdb5c 
* Fix for test flake when sync waiting and an intermediate error occurs (#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added

* Add WithLabel list filter to serving client lib (#1054)

* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>

* Update CHANGELOG

Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
@navidshaikh navidshaikh added backported-to/0.17 and removed backport/candidate Consider this PR to be backported to the release branch labels Oct 12, 2020
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Oct 12, 2020
@zroubalik @rhuss
Add WithLabel list filter to serving client lib (knative#1054)
4b075be 
* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>
dsimansk pushed a commit to dsimansk/client that referenced this pull request May 25, 2022
@matzew
🤖 CI was here...🔥 (knative#1054)
3d66f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien requested changes

@rhuss rhuss rhuss requested changes

@navidshaikh navidshaikh navidshaikh approved these changes

@sixolet sixolet Awaiting requested review from sixolet

@knative-prow-robot knative-prow-robot Awaiting requested review from knative-prow-robot

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WithLabel list filter to serving client lib
6 participants
@zroubalik @knative-prow-robot @knative-metrics-robot @maximilien @rhuss @navidshaikh