feat: List available channel types #1027

Kaustubh-pande · 2020-09-23T22:59:07Z

Description

List available channel types in the cluster which can be used for creating channels.

Changes

Add channel list-types

Reference

Fixes #979

knative-prow-robot

@Kaustubh-pande: 2 warnings.

In response to this:

Description

List available channel types in the cluster which can be used for creating channels.

Changes

Add channel list-types

Reference

Fixes #979

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/channel/list_types.go

lib/test/channel.go

knative-prow-robot · 2020-09-23T22:59:20Z

Hi @Kaustubh-pande. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maximilien

Thanks for contribution. Will do a full review. Let’s get the tests running first.

/ok-to-test

rhuss

Looks fine to me, but would love to have some review from @navidshaikh , too, as he did the source list-types (and this here is quite similar).

My only suggestion would be whether we might want reconsider the list-types name to simplify to types (although this would break our noun verb schema) But see the comment below.

rhuss · 2020-09-28T17:03:20Z

docs/cmd/kn_channel.md

@@ -31,4 +31,5 @@ kn channel COMMAND
 * [kn channel delete](kn_channel_delete.md)	 - Delete a channel
 * [kn channel describe](kn_channel_describe.md)	 - Show details of a channel
 * [kn channel list](kn_channel_list.md)	 - List channels
+* [kn channel list-types](kn_channel_list-types.md)	 - List channel types


While just thinking about this, why not just kn channel types ? I know this violates the schema, but it looks imo nice (same for kn source list-types). At the end "list-types" is also not a verb but an artificial word construct.
wdyt @navidshaikh @maximilien ?

I liked that. I'd keep it list-types for this PR and change for source and channel together in a subsequent PR (keeping list-types as an alias for source). cc @Kaustubh-pande

rhuss · 2020-09-28T17:31:45Z

pkg/dynamic/client_test.go

@@ -26,6 +26,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	dynamicfake "k8s.io/client-go/dynamic/fake"
 	eventingv1beta1 "knative.dev/eventing/pkg/apis/eventing/v1beta1"
+	messagingv1beta1 "knative.dev/eventing/pkg/apis/messaging/v1beta1"


I wonder whether we should already go to v1 API (and then change eventing also to v1 in a subsequent PR).

lets keep it at v1beta1 to also support working with earlier eventing installs?

daisy-ycguo · 2020-09-29T07:33:54Z

/assign daisy-ycguo

pkg/dynamic/client.go

navidshaikh

neat! There are a few suggestion as to which fields to print in the columns, we can remove Group and Version columns, and replace them with NAME and DESCRIPTION to align with kn source list-types.

pkg/dynamic/client.go

navidshaikh · 2020-09-29T11:17:51Z

pkg/dynamic/client_test.go

@@ -26,6 +26,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	dynamicfake "k8s.io/client-go/dynamic/fake"
 	eventingv1beta1 "knative.dev/eventing/pkg/apis/eventing/v1beta1"
+	messagingv1beta1 "knative.dev/eventing/pkg/apis/messaging/v1beta1"


lets keep it at v1beta1 to also support working with earlier eventing installs?

pkg/kn/commands/channel/flags.go

test/e2e/channels_test.go

daisy-ycguo

Thank you for your contribution, @Kaustubh-pande. I have a few comments. Would you address them and update a new version ?

pkg/dynamic/client.go

pkg/messaging/v1beta1/client.go

pkg/kn/commands/channel/flags.go

Kaustubh-pande · 2020-10-05T19:44:41Z

/retest

Kaustubh-pande · 2020-10-06T04:47:22Z

/retest

Kaustubh-pande · 2020-10-06T06:12:57Z

/retest

navidshaikh

lgtm, just a minor nit for the error message and please add the CHANGELOG entry ?

pkg/kn/commands/channel/list_types.go

daisy-ycguo · 2020-10-06T10:15:18Z

/test pull-knative-client-integration-tests

daisy-ycguo

LGTM.
After tests pass, I'm OK to merge it. Thank you for your contribution.

navidshaikh

/lgtm
/approve

rhuss · 2020-10-06T16:27:39Z

/retest

rhuss · 2020-10-06T16:27:54Z

/retest

knative-metrics-robot · 2020-10-06T16:32:08Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/dynamic/client.go	88.9%	88.5%	-0.4
pkg/dynamic/client_mock.go	90.9%	92.9%	1.9
pkg/kn/commands/channel/channel.go	57.1%	59.1%	1.9
pkg/kn/commands/channel/flags.go	53.5%	66.2%	12.7
pkg/kn/commands/channel/list_types.go	Do not exist	81.1%

rhuss · 2020-10-06T17:24:53Z

   ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
        🦆 kn service update svc3 --annotation alpha=direwolf --annotation brave- --namespace kne2etests7
        ┃ Updating Service 'svc3' in namespace 'kne2etests7':
        ┃ 
        ┃   0.045s The Configuration is still working to reflect the latest desired specification.
        ┃   0.404s Ingress reconciliation failed
        ┃ 
        🔥 Error: ReconcileIngressFailed: Ingress reconciliation failed
        🔥 Run 'kn --help' for usage
        🔥

/retest

navidshaikh · 2020-10-06T18:03:45Z

/retest

  result_collector.go:75: ERROR: Error: ReconcileIngressFailed: Ingress reconciliation failed

navidshaikh

/lgtm
/approve

knative-prow-robot · 2020-10-06T18:44:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, Kaustubh-pande, maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhuss · 2020-10-06T19:40:04Z

/retest

* add channel list-types * add kn channel list-types doc

knative-prow-robot requested review from cppforlife and maximilien September 23, 2020 22:59

knative-prow-robot reviewed Sep 23, 2020

View reviewed changes

pkg/kn/commands/channel/list_types.go Show resolved Hide resolved

lib/test/channel.go Show resolved Hide resolved

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 23, 2020

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2020

knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 23, 2020

maximilien approved these changes Sep 24, 2020

View reviewed changes

rhuss reviewed Sep 28, 2020

View reviewed changes

knative-prow-robot assigned daisy-ycguo Sep 29, 2020

navidshaikh reviewed Sep 29, 2020

View reviewed changes

pkg/dynamic/client.go Outdated Show resolved Hide resolved

navidshaikh requested changes Sep 29, 2020

View reviewed changes

daisy-ycguo suggested changes Sep 30, 2020

View reviewed changes

pkg/dynamic/client.go Outdated Show resolved Hide resolved

pkg/messaging/v1beta1/client.go Show resolved Hide resolved

pkg/kn/commands/channel/flags.go Outdated Show resolved Hide resolved

Kaustubh-pande force-pushed the channel-list-types branch from e1b6fcb to 3e2ffb7 Compare October 6, 2020 05:49

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2020

navidshaikh approved these changes Oct 6, 2020

View reviewed changes

pkg/kn/commands/channel/list_types.go Outdated Show resolved Hide resolved

daisy-ycguo approved these changes Oct 6, 2020

View reviewed changes

navidshaikh approved these changes Oct 6, 2020

View reviewed changes

knative-prow-robot assigned navidshaikh Oct 6, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020

navidshaikh changed the title ~~List available channel types~~ feat: List available channel types Oct 6, 2020

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2020

add channel list-types

dd32027

Kaustubh-pande force-pushed the channel-list-types branch from 2729f7b to dd32027 Compare October 6, 2020 13:00

knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 6, 2020

add kn channel list-types doc

295244d

rhuss closed this Oct 6, 2020

rhuss reopened this Oct 6, 2020

navidshaikh approved these changes Oct 6, 2020

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020

knative-prow-robot merged commit d9d5234 into knative:master Oct 6, 2020

rhuss pushed a commit to rhuss/knative-client that referenced this pull request Oct 12, 2020

feat: List available channel types (knative#1027)

db35e11

* add channel list-types * add kn channel list-types doc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: List available channel types #1027

feat: List available channel types #1027

Kaustubh-pande commented Sep 23, 2020

knative-prow-robot left a comment

knative-prow-robot commented Sep 23, 2020

maximilien left a comment

rhuss left a comment

rhuss Sep 28, 2020

navidshaikh Sep 29, 2020

rhuss Sep 28, 2020

navidshaikh Sep 29, 2020

daisy-ycguo commented Sep 29, 2020

navidshaikh left a comment •

edited

Loading

navidshaikh Sep 29, 2020

daisy-ycguo left a comment •

edited

Loading

Kaustubh-pande commented Oct 5, 2020

Kaustubh-pande commented Oct 6, 2020

Kaustubh-pande commented Oct 6, 2020

navidshaikh left a comment

daisy-ycguo commented Oct 6, 2020

daisy-ycguo left a comment

navidshaikh left a comment

rhuss commented Oct 6, 2020

rhuss commented Oct 6, 2020

knative-metrics-robot commented Oct 6, 2020

rhuss commented Oct 6, 2020

navidshaikh commented Oct 6, 2020

navidshaikh left a comment

knative-prow-robot commented Oct 6, 2020

rhuss commented Oct 6, 2020

feat: List available channel types #1027

feat: List available channel types #1027

Conversation

Kaustubh-pande commented Sep 23, 2020

Description

Changes

Reference

knative-prow-robot left a comment

Choose a reason for hiding this comment

Description

Changes

Reference

knative-prow-robot commented Sep 23, 2020

maximilien left a comment

Choose a reason for hiding this comment

rhuss left a comment

Choose a reason for hiding this comment

rhuss Sep 28, 2020

Choose a reason for hiding this comment

navidshaikh Sep 29, 2020

Choose a reason for hiding this comment

rhuss Sep 28, 2020

Choose a reason for hiding this comment

navidshaikh Sep 29, 2020

Choose a reason for hiding this comment

daisy-ycguo commented Sep 29, 2020

navidshaikh left a comment • edited Loading

Choose a reason for hiding this comment

navidshaikh Sep 29, 2020

Choose a reason for hiding this comment

daisy-ycguo left a comment • edited Loading

Choose a reason for hiding this comment

Kaustubh-pande commented Oct 5, 2020

Kaustubh-pande commented Oct 6, 2020

Kaustubh-pande commented Oct 6, 2020

navidshaikh left a comment

Choose a reason for hiding this comment

daisy-ycguo commented Oct 6, 2020

daisy-ycguo left a comment

Choose a reason for hiding this comment

navidshaikh left a comment

Choose a reason for hiding this comment

rhuss commented Oct 6, 2020

rhuss commented Oct 6, 2020

knative-metrics-robot commented Oct 6, 2020

rhuss commented Oct 6, 2020

navidshaikh commented Oct 6, 2020

navidshaikh left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Oct 6, 2020

rhuss commented Oct 6, 2020

navidshaikh left a comment •

edited

Loading

daisy-ycguo left a comment •

edited

Loading