Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common kn functionality for plugins and specialized Knative clients #763

Closed
1 of 4 tasks
maximilien opened this issue Mar 27, 2020 · 3 comments
Closed
1 of 4 tasks

Extract common kn functionality for plugins and specialized Knative clients #763

maximilien opened this issue Mar 27, 2020 · 3 comments
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@maximilien
Copy link
Contributor

maximilien commented Mar 27, 2020 •
edited
Loading

Feature request

In creating Knative source plugins we discovered that there various parts of Kn that should be easily usable. For example setting up namespace and sync flags. So are creating e2e tests for the plugins.

Much of the functionality above should be usable (so exported) and to avoid closely linking these common libraries with the release cycle of kn it's best to extract these into their own repo.

In the discussion of PR #748 we have collected a series of items that should be extracted:

Use case

  • plugins for Knative eventing sources
  • other plugins
  • customized Knative clients (private clients)

UI Example

N/A

/kind cleanup
/kind refactoring
@maximilien maximilien added the kind/feature New feature or request label Mar 27, 2020
@maximilien
Copy link
Contributor Author

maximilien commented Mar 27, 2020 •
edited
Loading

Submitting a PR now to refactor common e2e (integration) test code to address part of this issue. This will help @daisy-ycguo and I to complete our kn-source-pkg (common code), kn-source-github, and kn-source-kafka plugins.

cc: @rhuss @navidshaikh please review ASAP to unblock us. Thx

maximilien added a commit to maximilien/client that referenced this issue Mar 27, 2020
@maximilien
(refactor): partial fix for issue knative#763 by refactoring common e…
1412d56 
…2e code
@maximilien maximilien mentioned this issue Mar 27, 2020
Closed
maximilien added a commit to maximilien/client that referenced this issue Mar 27, 2020
@maximilien
(refactor): partial fix for issue knative#763 by refactoring common e…
241757d 
…2e code
maximilien added a commit to maximilien/client that referenced this issue Mar 27, 2020
@maximilien
(refactor) address the e2e extract / refactor of issue knative#763
df3334c
@maximilien maximilien mentioned this issue Mar 27, 2020
Merged
@daisy-ycguo daisy-ycguo mentioned this issue Mar 27, 2020
Closed
knative-prow-robot pushed a commit that referenced this issue Apr 1, 2020
@maximilien
(refactor) address the e2e extract / refactor of issue #763 (#765)
df78b8b 
* (refactor) address the e2e extract / refactor of issue #763

* various updates to address reviewers feedback

* renamed lib/test/integration to lib/test and package to test
rhuss pushed a commit to rhuss/knative-client that referenced this issue Apr 15, 2020
@maximilien @rhuss
(refactor) address the e2e extract / refactor of issue knative#763 (k…
e1b43e9 
…native#765)

* (refactor) address the e2e extract / refactor of issue knative#763

* various updates to address reviewers feedback

* renamed lib/test/integration to lib/test and package to test

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	CHANGELOG.adoc
#	test/e2e/service_export_import_apply_test.go
#	test/e2e/trigger_test.go
knative-prow-robot pushed a commit that referenced this issue Apr 15, 2020
@rhuss @maximilien
@dsimansk @navidshaikh @MIBc @itsmurugappan
Pr/release 0.13.2 backports (#806)
b67f302 
* (refactor) address the e2e extract / refactor of issue #763 (#765)

* (refactor) address the e2e extract / refactor of issue #763

* various updates to address reviewers feedback

* renamed lib/test/integration to lib/test and package to test

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	CHANGELOG.adoc
#	test/e2e/service_export_import_apply_test.go
#	test/e2e/trigger_test.go

* fix(plugin): Fix plugin lookup with file ext on Windows (#774)

* fix(plugin): Fix plugin lookup with file ext on Windows

* chore: Update changelog

* fix: Reflect review feedback

* fix: Reflect review feedback and add future todo

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	CHANGELOG.adoc

* fix(issue #762): correct error message when updating service (#778)

* fix(issue #762): correct error message when updating service

* correct message when updating service and passing many names
* fix issue with TestServiceUpdateWithMultipleImages running create vs update

* * added TestServiceDescribeWithMultipleNames
* added TestServiceCreateWithMultipleNames
* fix error message for service delete since many names can be passed

* Use vendored deps while running e2e locally (#783)

Also set GO111MODULE=on unconditionally

* Update sink binding create usage string (#785)

* Add "--target-utilization" to manage "autoscaling.knative.dev/targetUtilizationPercentage" annotation (#788)

* Support setting "autoscaling.knative.dev/targetUtilizationPercentage" annotation.

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	test/e2e/service_options_test.go

* Remove the delete propagation flag (#770)

* Remove the delete propagation flag

In it's current state it now takes me about 25 seconds for the `kn delete`
to complete. Before #682 it used to be
almost immediate. This is because we now pass in the
`DeletePropagationBackground` flag. I believe this is a mistake, not only
because of the 20+ seconds of additional time to delete things, but IMO
the CLI should talk to the server in the same way regardless of the --wait
flag. That flag should just be a CLI thing to indicate if the user wants the CLI
to wait for the server to complete but not HOW the server should do the delete.

Signed-off-by: Doug Davis <[email protected]>

* try just tweaking the --no-wait flag

Signed-off-by: Doug Davis <[email protected]>

* Fix error when output is set to name (#775)

* fix error when output is set to name

* add e2e test

* change to flags/listprint.go

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	test/e2e/basic_workflow_test.go

* Show all revisions when run `service describe -v` (#790)

* The `kn service describe -v` command shows repetitive revisions, because
  the revision would be covered by next one.

* Fix resource listing with -oname flag (#799)

* Fix resource listing with -oname flag

* add e2e tests

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	test/e2e/ping_test.go
#	test/e2e/revision_test.go
#	test/e2e/route_test.go
#	test/e2e/source_apiserver_test.go
#	test/e2e/source_binding_test.go
#	test/e2e/trigger_test.go

* Make wait, no-wait and async flags per bool var CLI convention (#802)

* Make wait, no-wait and async flags per bool var CLI convention

 Fixes #800

 - Deprecated bool vars can be supported for CLI convention
 - Bind --async flag value to --no-wait
 - Only one flag among [wait, no-wait, async] can be provided, else raise an error

* Simplify conditionals

* Add unit tests for deprecated flag async

* Fix a typo

* e2e: Foreground delete for revisions and services in e2e (#794)

* e2e: Foreground delete for revisions and services in e2e

 to avoid any race conditions and flakes

* Use --wait instead of --no-wait=false

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	test/e2e/basic_workflow_test.go
#	test/e2e/revision_test.go

* e2e: Run tekton e2e against pipeline v0.11.1 (#803)

* Use buildah task from master branch and paramterize FORMAT

* Configure pipeline v0.11.1

* DNM: Run tekton e2e in this PR

* Revert "DNM: Run tekton e2e in this PR"

This reverts commit 903f5be.

* Update CHANGELOG for v0.13.2 (#804)

* Pin serving to v0.13.2 and update version command (#797)

* Pin serving v0.13.2 dep to v0.13.2

* Update version command

 now points to serving v0.13.2 and eventing v0.13.6

* Copy go.sum as generated in CI

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	go.mod
#	go.sum
#	vendor/modules.txt

* add missing vendored files

* fixed error reporting for traffics tests

* Updated test

* fix formatting

* e2e for service export (#739)

* e2e for service export

* e2e for service export

* e2e for service export

* e2e for service export

* e2e for service export

Signed-off-by: Roland Huß <[email protected]>
# Conflicts:
#	test/e2e/service_export_import_apply_test.go

Co-authored-by: dr.max <[email protected]>
Co-authored-by: David Simansky <[email protected]>
Co-authored-by: Navid Shaikh <[email protected]>
Co-authored-by: Lv Jiawei <[email protected]>
Co-authored-by: Doug Davis <[email protected]>
Co-authored-by: Ying Chun Guo <[email protected]>
Co-authored-by: Murugappan Chetty <[email protected]>
@rhuss rhuss mentioned this issue Jun 8, 2020
Merged
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@maximilien
Copy link
Contributor Author

We could probably close this as well since it’s kind of done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maximilien