Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"kn service export" should also export service annotations #724

Closed
rhuss opened this issue Mar 10, 2020 · 2 comments
Closed

"kn service export" should also export service annotations #724

rhuss opened this issue Mar 10, 2020 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@rhuss
Copy link
Contributor

rhuss commented Mar 10, 2020

Bug report

At the moment, kn export does not export annotations.

Expected behavior

User provided annotations should be exported as well (like with kn service create --annotation). Maybe filter out some automatically added annotations (if known), but that might be difficult.

Adding an E2E test is a plus.

Steps to reproduce the problem

  • Create a service with annotation: kn service create mysvc --annotation myanno=value someimage
  • Export its: kn service export mysvc
  • Check whether the annotation is included.
@rhuss rhuss added the kind/bug Categorizes issue or PR as related to a bug. label Mar 10, 2020
@rhuss rhuss changed the title kn service export should also export service annotations "kn service export" should also export service annotations Mar 10, 2020
@itsmurugappan
Copy link
Contributor

/assign @itsmurugappan

@itsmurugappan
Copy link
Contributor

@rhuss this was fixed by #819.

@rhuss rhuss closed this as completed May 5, 2020
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants