Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to "kn source list" test E2E tests cases #722

Closed
rhuss opened this issue Mar 10, 2020 · 1 comment · Fixed by #924
Closed

Add to "kn source list" test E2E tests cases #722

rhuss opened this issue Mar 10, 2020 · 1 comment · Fixed by #924
Assignees
@Kaustubh-pande
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request
Milestone
v0.16.0

Comments

@rhuss
Copy link
Contributor

rhuss commented Mar 10, 2020

We should add additional E2E test cases for kn source list for checking:

  • Invalid filter options
  • Heterogenous list of different types with -o yaml (would involve to combine a pingsource + apiserver source creation)

/kind feature
@knative-prow-robot knative-prow-robot added the kind/feature New feature or request label Mar 10, 2020
@rhuss rhuss added the good first issue Denotes an issue ready for a new contributor. label Mar 10, 2020
@rhuss rhuss changed the title Add to kn source list test E2E tests cases Add to "kn source list" test E2E tests cases Mar 10, 2020
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@srinivashegde86 @knative-prow-robot
Add license header to all coverage files (knative#722)
c76aba1 
* Add license header to all coverage files

* Fix test that is looking at line numbers
@navidshaikh navidshaikh removed their assignment Jul 1, 2020
@Kaustubh-pande
Copy link
Contributor

/assign

@navidshaikh navidshaikh added this to the v0.16.0 milestone Jul 6, 2020
@Kaustubh-pande Kaustubh-pande mentioned this issue Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kaustubh-pande Kaustubh-pande

Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

Add E2E test cases for "kn source list". Kaustubh-pande/client
4 participants
@rhuss @navidshaikh @knative-prow-robot @Kaustubh-pande