Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --wait and --no-wait for all delete operation #671

Closed
rhuss opened this issue Feb 17, 2020 · 5 comments · Fixed by #682 or #688
Closed

Add --wait and --no-wait for all delete operation #671

rhuss opened this issue Feb 17, 2020 · 5 comments · Fixed by #682 or #688
Assignees
@dsimansk
Labels
kind/feature New feature or request
Milestone
v0.13.0

Comments

@rhuss
Copy link
Contributor

rhuss commented Feb 17, 2020

In what area(s)?

Describe the feature:

In order to avoid race conditions when on delete an object and immediately recreate it, by default we should also wait for the end of a delete operation, like we do for service create and service update.

Therefor a --wait and a --no-wait option should be added to all "delete" operation. This can reuse our general wait handling util libs.
@rhuss rhuss added the kind/feature New feature or request label Feb 17, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Feb 17, 2020

/assign dsimansk

@rhuss
Copy link
Contributor Author

rhuss commented Feb 17, 2020

See knative/serving#6876 for some example where this option is useful.

I think also that --wait should be the default.

@dsimansk dsimansk mentioned this issue Feb 19, 2020
Merged
@dsimansk
Copy link
Contributor

dsimansk commented Feb 21, 2020 •
edited
Loading

PR #682 extends current wait functionality to allow waiting for various events.

To complete this issue synchronous delete op should be used for:

  • service delete
  • revision delete.

@dsimansk
Copy link
Contributor

/reopen

To do: sync revision delete.

@knative-prow-robot
Copy link
Contributor

@dsimansk: Reopened this issue.

In response to this:

/reopen

To do: sync revision delete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk dsimansk mentioned this issue Feb 26, 2020
Merged
@navidshaikh navidshaikh added this to the v0.13.0 milestone Feb 28, 2020
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@chaodaiG @knative-prow-robot
E2E clusters creation retry different regions/zones (knative#671)
7076a4a 
* retry different regions/zones

* update with PR comments

* Update scripts/README.md

Co-Authored-By: chaodaiG <[email protected]>

* update based on PR feedback

* Update scripts/e2e-tests.sh

Co-Authored-By: chaodaiG <[email protected]>

* update based on PR feedback
mgencur pushed a commit to openshift-knative/client that referenced this issue Nov 21, 2022
@maschmid
Poke CI (knative#671)
e672eed 
* Poke CI

* 0.17.2 svc.ci -> ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsimansk dsimansk

Labels
kind/feature New feature or request
Projects
None yet
Milestone
v0.13.0
4 participants
@rhuss @navidshaikh @dsimansk @knative-prow-robot