Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sink/subscriber support #563

Closed
2 of 3 tasks
rhuss opened this issue Dec 17, 2019 · 5 comments
Closed
2 of 3 tasks

Improve sink/subscriber support #563

rhuss opened this issue Dec 17, 2019 · 5 comments
Assignees
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rhuss
Copy link
Contributor

rhuss commented Dec 17, 2019

In what area(s)?

Eventing

Describe the feature:

The following features are needed for proper sink/subscriber handling:

  • * Add more sink types like define in the spec
  • * Allow an URL to be provided
  • * Allow specifying the namespace for the sink (currently: Always default)
@rhuss rhuss added kind/feature New feature or request topic/eventing-mvp labels Dec 17, 2019
@sixolet sixolet self-assigned this Dec 18, 2019
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@navidshaikh
Copy link
Collaborator

Broker, knative service and URL can be specified, more types can be configured via sink prefixes in the config.

Currently sink is looked up in the namespace kn is operating in, updated issue description with unchecked item for specifying namespace of the sink.

@lionelvillard
Copy link
Member

Since sources natively support sending events to plain k8s services, it'd be nice to provide a shortcut, e.g. svc:my-svc.

@rhuss
Copy link
Contributor Author

rhuss commented Jul 21, 2020

Since sources natively support sending events to plain k8s services, it'd be nice to provide a shortcut, e.g. svc:my-svc.

We discussed this, but we felt that referring to vanilla Kubernetes objects is outside the 'Knative contract'. (e.g. will it also work on CloudRun ?).

See #898 for a more in depth discussion on this topic.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Nov 26, 2020

Although this issue has been closed, I think we should still think about how to allow the specification of a different namespace for a cross-namespace eventing mesh.

I create a new issue for this: #1143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants