Flaky smoke test

[rhuss]

In https://storage.googleapis.com/knative-prow/pr-logs/pull/knative_client/221/pull-knative-client-integration-tests-latest-release/1146230064891826179/build-log.txt there is still a flaky test:

namespace/kne2esmoketests created
Service 'svc1' successfully created in namespace 'kne2esmoketests'.
Service 'hello' successfully created in namespace 'kne2esmoketests'.
Waiting for service 'hello' to become ready ... OK

Service URL:
http://hello.kne2esmoketests.example.com
NAME    DOMAIN   GENERATION   AGE   CONDITIONS   READY   REASON
hello            1            48s   3 OK / 3     True    
svc1             1            48s   3 OK / 3     True    
Service 'hello' updated in namespace 'kne2esmoketests'.
NAME          SERVICE   AGE   CONDITIONS   READY   REASON
hello-dm9gg   hello     29s   4 OK / 4     True    
svc1-z7kbh    svc1      29s   4 OK / 4     True    
NAME    DOMAIN   GENERATION   AGE   CONDITIONS   READY   REASON
hello            1            48s   3 OK / 3     True    
svc1             1            48s   3 OK / 3     True    
Operation cannot be fulfilled on services.serving.knative.dev "hello": the object has been modified; please apply your changes to the latest version and try again

This is exactly this test:

./kn service create hello --force --image gcr.io/knative-samples/helloworld-go -e TARGET=Awesome -n $KN_E2E_SMOKE_TESTS_NAMESPACE || fail_test

So I suspect that there is an issue with replacing an existing service like this in our replacement code:

func replaceService(client v1alpha1.KnClient, service *serving_v1alpha1_api.Service, namespace string, out io.Writer) error {
	existingService, err := client.GetService(service.Name)
	if err != nil {
		return err
	}
	service.ResourceVersion = existingService.ResourceVersion
	err = client.UpdateService(service)
	if err != nil {
		return err
	}
	fmt.Fprintf(out, "Service '%s' successfully replaced in namespace '%s'.\n", service.Name, namespace)
	return nil
}

[rhuss]

Another flake:

Failed to successfully execute 'kn service create hello --image gcr.io/knative-samples/helloworld-go -n kne2etests': Execution error: stderr: 'RevisionMissing: Configuration "hello" does not have any ready Revision.
' error: 'exit status 1'FAIL	github.com/knative/client/test/e2e	0.602s

[navidshaikh]

Another one:

Failed to successfully execute 'kn service create hello --image gcr.io/knative-samples/helloworld-go -n kne2etests': Execution error: stderr: 'timeout: service 'hello' not ready after 60 seconds

@rhuss : probably we should increase the timeout seconds default to say 120 seconds ?

[rhuss]

@navidshaikh for the shell based tests I already did that I thought. That large timeout is only needed on the first creat as the image pull will eat up the default timeout.

[navidshaikh]

I think this is fixed.