Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement kn revision describe command #206

Closed
navidshaikh opened this issue Jun 25, 2019 · 11 comments
Closed

Implement kn revision describe command #206

navidshaikh opened this issue Jun 25, 2019 · 11 comments
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@navidshaikh
Copy link
Collaborator

with kn revision describe taking an argument for revision name

@zhangtbj
Copy link
Contributor

zhangtbj commented Jul 5, 2019

Hi @navidshaikh ,

I saw the kn revision describe is implemented here:
https://github.com/knative/client/blob/master/pkg/kn/commands/revision/revision_describe.go

I think it is already finished. correctly?

@navidshaikh
Copy link
Collaborator Author

Hi @zhangtbj : Present kn revision describe prints the yaml output of the object, the goal is to present the revision object in better human readable format with some additional details.

@zhangtbj
Copy link
Contributor

zhangtbj commented Jul 5, 2019

Thx @navidshaikh , now I see the yaml output is native revision information output from kube. And kn client also provides other formats like json, name....

what is mean better human readable format? And is there any rule or standard that how to present?

@zhangtbj
Copy link
Contributor

zhangtbj commented Jul 5, 2019

Oh, I saw the format is discussed in this PR:
#75

Let us also discuss there. Thanks

@rhuss
Copy link
Contributor

rhuss commented Jul 5, 2019

@zhangtbj I will split up the #75 PR soonish, focussing first on the non-color options. There won't be much activity on this PR anymore therefor.

At #235 I started a discussion about the general nature of kn <noun> describe, so its worth to watch and comment on this, too.

@sixolet sixolet added this to the v0.8.0 milestone Jul 9, 2019
@sixolet sixolet added the kind/feature New feature or request label Jul 11, 2019
@navidshaikh
Copy link
Collaborator Author

/assign

@navidshaikh
Copy link
Collaborator Author

/assign @rhuss

@navidshaikh
Copy link
Collaborator Author

/unassign @rhuss @navidshaikh
/assign @sixolet

@navidshaikh
Copy link
Collaborator Author

This is the only issue pending for v0.8.0 milestone, can we scope this for next milestone and cut v0.8.0?

@rhuss @sixolet @maximilien WDYT ?

@rhuss
Copy link
Contributor

rhuss commented Oct 22, 2019

I'm fine with postponing this feature for the next release, we already have made quite some progress since 0.2.0 which would justify a release on its own.

@rhuss rhuss modified the milestones: v0.8.0, v0.10.0 Oct 30, 2019
@navidshaikh
Copy link
Collaborator Author

Implemented by #475
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants