Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVK is hard-coded to wrong coordinates #133

Closed
rhuss opened this issue May 20, 2019 · 0 comments · Fixed by #134
Closed

GVK is hard-coded to wrong coordinates #133

rhuss opened this issue May 20, 2019 · 0 comments · Fixed by #134
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented May 20, 2019

E.g. in

the GroupVersionKind is hardcoded.

In fact, it should be obtained via from the client library and not hardcoded.

@rhuss rhuss changed the title Group/API version hard coded GKV version hard coded May 20, 2019
@rhuss rhuss changed the title GKV version hard coded GKV hard coded May 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue May 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue May 20, 2019
@rhuss rhuss changed the title GKV hard coded GVK is hard-coded to wrong coordinates May 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue May 20, 2019
@sixolet sixolet added this to the v0.2.0 milestone May 28, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue May 30, 2019
This is an alternate solution to knative#134 for fixing knative#133. In this commit
the update of the GVK coordinates are moved to the resource printer.
rhuss added a commit to rhuss/knative-client that referenced this issue May 31, 2019
@rhuss rhuss mentioned this issue Jun 2, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 3, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 8, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 8, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 14, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 15, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 21, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 29, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 29, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 29, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 2, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 2, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 2, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 3, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 5, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 8, 2019
knative-prow-robot pushed a commit that referenced this issue Jul 8, 2019
…ess (#134)

* fix(serving): Remove hardcoded GVK and look it up from schema

Fixes #133.

* chore(serving): Add test for "WaitForService()"

* refactor(service): Add listRoutes() to client + generic way for list options

* chore(serving): Fixing rebase conflicts
dsimansk added a commit to dsimansk/client that referenced this issue Jun 29, 2023
* fix: Check if release branch exists

* Reflect review suggestion

---------

Co-authored-by: David Simansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants