-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GVK is hard-coded to wrong coordinates #133
Milestone
Comments
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
May 20, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
May 20, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
May 20, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
May 30, 2019
This is an alternate solution to knative#134 for fixing knative#133. In this commit the update of the GVK coordinates are moved to the resource printer.
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
May 31, 2019
Closed
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 3, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 8, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 8, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 14, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 15, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 20, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 20, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 21, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 29, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 29, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 29, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 2, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 2, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 2, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 3, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 5, 2019
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jul 8, 2019
dsimansk
added a commit
to dsimansk/client
that referenced
this issue
Jun 29, 2023
* fix: Check if release branch exists * Reflect review suggestion --------- Co-authored-by: David Simansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
E.g. in
client/pkg/kn/commands/service_get.go
Lines 50 to 51 in bd7d57f
client/pkg/kn/commands/service_describe.go
Lines 54 to 57 in a264f06
the
GroupVersionKind
is hardcoded.In fact, it should be obtained via from the client library and not hardcoded.
The text was updated successfully, but these errors were encountered: