Skip to content

Commit

Permalink
Updates CHANGELOG and flag help text
Browse files Browse the repository at this point in the history
  • Loading branch information
navidshaikh committed Aug 8, 2019
1 parent e775345 commit b059f4d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
| List revisions sorted by configuration generation
| https://github.com/knative/client/pull/332[#332]

| 🎁
| Support providing multiple comma separated values for --env flag
|https://github.com/knative/client/pull/347[#347]

|===

## v0.2.0 (2019-07-10)
Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_service_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ kn service create NAME --image IMAGE [flags]
--async Create service and don't wait for it to become ready.
--concurrency-limit int Hard Limit of concurrent requests to be processed by a single replica.
--concurrency-target int Recommendation for when to scale up based on the concurrent number of incoming request. Defaults to --concurrency-limit when given.
-e, --env strings Environment variable to set. NAME=value; you may provide this flag any number of times to set multiple environment variables.
-e, --env strings Environment variable to set. Format: NAME=value; you may repeat this flag any number of times to set multiple environment variables. Supports comma separated values for a flag as well (e.g.: --env K1=V1,K2=v2).
--force Create service forcefully, replaces existing service if any.
-h, --help help for create
--image string Image to run.
Expand Down
2 changes: 1 addition & 1 deletion docs/cmd/kn_service_update.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ kn service update NAME [flags]
--async Update service and don't wait for it to become ready.
--concurrency-limit int Hard Limit of concurrent requests to be processed by a single replica.
--concurrency-target int Recommendation for when to scale up based on the concurrent number of incoming request. Defaults to --concurrency-limit when given.
-e, --env strings Environment variable to set. NAME=value; you may provide this flag any number of times to set multiple environment variables.
-e, --env strings Environment variable to set. Format: NAME=value; you may repeat this flag any number of times to set multiple environment variables. Supports comma separated values for a flag as well (e.g.: --env K1=V1,K2=v2).
-h, --help help for update
--image string Image to run.
--limits-cpu string The limits on the requested CPU (e.g., 1000m).
Expand Down
5 changes: 3 additions & 2 deletions pkg/kn/commands/service/configuration_edit_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ type ResourceFlags struct {
func (p *ConfigurationEditFlags) AddUpdateFlags(command *cobra.Command) {
command.Flags().StringVar(&p.Image, "image", "", "Image to run.")
command.Flags().StringSliceVarP(&p.Env, "env", "e", []string{},
"Environment variable to set. NAME=value; you may provide this flag "+
"any number of times to set multiple environment variables.")
"Environment variable to set. Format: NAME=value; you may repeat this flag "+
"any number of times to set multiple environment variables. "+
"Supports comma separated values for a flag as well (e.g.: --env K1=V1,K2=v2).")
command.Flags().StringVar(&p.RequestsFlags.CPU, "requests-cpu", "", "The requested CPU (e.g., 250m).")
command.Flags().StringVar(&p.RequestsFlags.Memory, "requests-memory", "", "The requested memory (e.g., 64Mi).")
command.Flags().StringVar(&p.LimitsFlags.CPU, "limits-cpu", "", "The limits on the requested CPU (e.g., 1000m).")
Expand Down

0 comments on commit b059f4d

Please sign in to comment.