-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
c43ba58
to
d647782
Compare
test/README.md
Outdated
@@ -0,0 +1,48 @@ | |||
# Test | |||
|
|||
This directory contains tests and testing dockes for `Knative Build`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: dockes
test/README.md
Outdated
|
||
## Running end to end tests | ||
|
||
To run [the e2e tests](./e2e) and [the conformance tests](./conformance), you need to have a running environment that meets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo doesn't have conformance tests (yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh dang it, I though I removed it 😅
test/README.md
Outdated
[the e2e test environment requirements](#environment-requirements), and you need to specify the build tag `e2e`. | ||
|
||
```bash | ||
go test -v -tags=e2e -count=1 ./test/e2e/... -count=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate -count=1
flag
test/README.md
Outdated
|
||
These tests require: | ||
|
||
1. [A running `Knative Serving` cluster.](/DEVELOPMENT.md#getting-started) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need Serving components to run Build tests, and our tests create the namespace for us so #2 is unnecessary.
test/README.md
Outdated
|
||
### One test case | ||
|
||
To run one e2e test case, e.g. TestAutoscaleUpDownUp, use [the `-run` flag with `go test`](https://golang.org/cmd/go/#hdr-Testing_flags): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo doesn't have TestAutoscaleUpDownUp, we should use TestSimpleBuild as an example instead.
test/README.md
Outdated
|
||
kubectl label namespace build-tests istio-injection=enabled | ||
``` | ||
3. A docker repo containing [the test images](#test-images) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our tests don't have test images (yet), so this step can be removed.
test/e2e/README.md
Outdated
|
||
`-count=1` is the idiomatic way to bypass test caching, so that tests will | ||
always run. | ||
Knative Serving e2e tests [test the end to end functionality of the Knative Serving API](#requirements) to verify the behavior of this specific implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serving -> Build
Taking from `serving` `test/README`(s), this updates the documentation to run the unit tests and e2e tests locally. Signed-off-by: Vincent Demeester <[email protected]>
d647782
to
0ce375f
Compare
/ok-to-test |
Signed-off-by: Vincent Demeester <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-build-unit-tests |
I have added an issue to fix the unit tests |
I would prefer adding a flag to |
* Update test documentation Taking from `serving` `test/README`(s), this updates the documentation to run the unit tests and e2e tests locally. Signed-off-by: Vincent Demeester <[email protected]> * Add e2e YAML tests documentation and (local) script Signed-off-by: Vincent Demeester <[email protected]> * Update README.md
* Update test documentation Taking from `serving` `test/README`(s), this updates the documentation to run the unit tests and e2e tests locally. Signed-off-by: Vincent Demeester <[email protected]> * Add e2e YAML tests documentation and (local) script Signed-off-by: Vincent Demeester <[email protected]> * Update README.md
Taking from
serving
test/README
(s), this updates the documentationto run the unit tests and e2e tests locally.
/cc @shashwathi @imjasonh
Signed-off-by: Vincent Demeester [email protected]