Skip to content
This repository was archived by the owner on Sep 5, 2019. It is now read-only.

Add node affinity and pod affinity/anti-affinity.#237

Closed
shashwathi wants to merge 2 commits intoknative:masterfrom
shashwathi:add-affinity
Closed

Add node affinity and pod affinity/anti-affinity.#237
shashwathi wants to merge 2 commits intoknative:masterfrom
shashwathi:add-affinity

Conversation

@shashwathi
Copy link
Contributor

Fixes #116

Proposed Changes

  • Allow Builds to specify node affinity, pod affinity/anti-affinity.

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shashwathi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: imjasonh

If they are not already assigned, you can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@evankanderson
Copy link
Member

/assign @imjasonh

Copy link
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to add an e2e test for this, even if the affinity/anti-affinity is vacuously satisfied (e.g., affinity matching any node, anti-affinity matching no nodes)

That way we can at least check that specifying affinity doesn't break a build.

@shashwathi
Copy link
Contributor Author

@imjasonh : Sure. I can do that

  • I will close this PR and submit another one from new fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants