Skip to content

eventshub forwarder, don't clone Host header#692

Merged
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
maschmid:maschmid-fix-forwarder-host-header-cloning
Mar 19, 2024
Merged

eventshub forwarder, don't clone Host header#692
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
maschmid:maschmid-fix-forwarder-host-header-cloning

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

@maschmid maschmid commented Mar 18, 2024

  • 🧹 eventshub forwarder, don't clone the Host header of the original request

@knative-prow knative-prow bot requested review from cardil and upodroid March 18, 2024 18:00
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Mar 19, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@knative-prow knative-prow bot merged commit 56cee28 into knative-extensions:main Mar 19, 2024
@maschmid
Copy link
Copy Markdown
Contributor Author

maschmid commented Mar 19, 2024

/cherry-pick release-1.13

@maschmid
Copy link
Copy Markdown
Contributor Author

maschmid commented Mar 19, 2024

/cherry-pick release-1.12

@knative-prow-robot knative-prow-robot mentioned this pull request Mar 19, 2024
Merged
@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Mar 19, 2024

@maschmid: new pull request created: #693

Details

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Mar 19, 2024

@maschmid: new pull request created: #694

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr approved these changes

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@mgencur mgencur

@creydr creydr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maschmid @mgencur @knative-prow-robot @creydr