Skip to content

Add hold annotation for istio-proxy#576

Merged
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
ReToCode:istio-annotations
Aug 17, 2023
Merged

Add hold annotation for istio-proxy#576
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
ReToCode:istio-annotations

Conversation

@ReToCode
Copy link
Copy Markdown
Contributor

@ReToCode ReToCode commented Aug 17, 2023

Changes

/kind enhancement

@knative-prow knative-prow bot requested review from cardil and upodroid August 17, 2023 04:48
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2023
@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Aug 17, 2023

/assign @mgencur

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi August 17, 2023 04:49
@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Aug 17, 2023

/cherry-pick release-1.10

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Aug 17, 2023

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.10

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Aug 17, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Aug 17, 2023

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode ReToCode mentioned this pull request Aug 17, 2023
Merged
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Aug 17, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Aug 17, 2023

/approve

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Aug 17, 2023

/cc @matzew

@knative-prow knative-prow bot requested a review from matzew August 17, 2023 06:06
matzew
matzew approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@knative-prow knative-prow bot merged commit 39774f1 into knative-extensions:main Aug 17, 2023
@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Aug 17, 2023

@ReToCode: new pull request created: #577

Details

In response to this:

/cherry-pick release-1.10

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 17, 2023
Merged
Merged
@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Aug 17, 2023

@ReToCode: new pull request created: #578

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

@mgencur mgencur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ReToCode @knative-prow-robot @mgencur @matzew