Support for configuring envoy connection parameters in ingress, which istio currently supports. #873

shengyanli1982 · 2022-07-11T11:31:16Z

Changes

configuring envoy connection parameters from ingress annotations resource by user defined

/kind enhancement

Fixes #

Release Note

The current project only use default values envoy connection parameters and are not configured for connections to clusters created by ingress. now, can configuring envoy connection parameters from ingress annotations resource by user defined.

Unit Test

=== RUN   TestIngressTranslator
--- PASS: TestIngressTranslator (0.04s)
=== RUN   TestIngressTranslator/simple
    --- PASS: TestIngressTranslator/simple (0.01s)
=== RUN   TestIngressTranslator/tls
    --- PASS: TestIngressTranslator/tls (0.01s)
=== RUN   TestIngressTranslator/tls_redirect
    --- PASS: TestIngressTranslator/tls_redirect (0.01s)
=== RUN   TestIngressTranslator/tls_redirect_cluster_local
    --- PASS: TestIngressTranslator/tls_redirect_cluster_local (0.00s)
=== RUN   TestIngressTranslator/split
    --- PASS: TestIngressTranslator/split (0.01s)
=== RUN   TestIngressTranslator/path_defaulting
    --- PASS: TestIngressTranslator/path_defaulting (0.00s)
=== RUN   TestIngressTranslator/external_service
    --- PASS: TestIngressTranslator/external_service (0.00s)
=== RUN   TestIngressTranslator/external_service_without_service_port
    --- PASS: TestIngressTranslator/external_service_without_service_port (0.00s)
=== RUN   TestIngressTranslator/missing_service
{"level":"warn","ts":1657538878.371255,"logger":"fallback","caller":"generator/ingress_translator.go:193","msg":"Service 'servicens/servicename' not yet created"}
    --- PASS: TestIngressTranslator/missing_service (0.00s)
=== RUN   TestIngressTranslator/missing_endpoints
{"level":"warn","ts":1657538878.371395,"logger":"fallback","caller":"generator/ingress_translator.go:236","msg":"Endpoints 'servicens/servicename' not yet created"}
    --- PASS: TestIngressTranslator/missing_endpoints (0.00s)
PASS

Envoy Config Dump

"circuit_breakers": {
    "thresholds": [
     {
      "max_connections": 4294967295,
      "max_pending_requests": 4294967295,
      "max_requests": 4294967295,
      "max_retries": 10
     },
     {
      "priority": "HIGH",
      "max_connections": 4294967295,
      "max_pending_requests": 4294967295,
      "max_requests": 4294967295,
      "max_retries": 10
     }
    ]
}

… istio currently supports.

linux-foundation-easycla · 2022-07-11T11:31:18Z

❌ The commit (d6461e4, 999d16e, 0f7e68f). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

knative-prow · 2022-07-11T11:31:26Z

Welcome @shengyanli1982! It looks like this is your first PR to knative-sandbox/net-kourier 🎉

knative-prow · 2022-07-11T11:31:27Z

Hi @shengyanli1982. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow · 2022-07-18T05:39:47Z

@shengyanli1982: The label(s) sig/apps cannot be applied, because the repository doesn't have them.

In response to this:

/sig apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shengyanli1982 · 2022-07-18T05:52:03Z

/assign @dprotaso

shengyanli1982 · 2022-07-18T05:59:31Z

/test all

knative-prow · 2022-07-18T05:59:50Z

@shengyanli1982: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dprotaso · 2022-07-18T14:15:52Z

/assign @nak3
/unassign @dprotaso

Not familiar with kourier enough to review this

dprotaso · 2022-07-18T14:16:07Z

/ok-to-test

pkg/generator/ingress_translator.go

+	if mc, ok := ingress.Annotations[envoyClusterMaxConnections]; ok {
+		if v, err := strconv.Atoi(mc); err == nil {
+			if v > 0 && v < math.MaxUint32 {
+				connectionOpts.MaxConnections = uint32(v)


pkg/generator/ingress_translator.go

+	if mpr, ok := ingress.Annotations[envoyClusterMaxPendingRequests]; ok {
+		if v, err := strconv.Atoi(mpr); err == nil {
+			if v > 0 && v < math.MaxUint32 {
+				connectionOpts.MaxPendingRequests = uint32(v)


pkg/generator/ingress_translator.go

+	if mr, ok := ingress.Annotations[envoyClusterMaxRequests]; ok {
+		if v, err := strconv.Atoi(mr); err == nil {
+			if v > 0 && v < math.MaxUint32 {
+				connectionOpts.MaxRequests = uint32(v)


pkg/generator/ingress_translator.go

+	if mrt, ok := ingress.Annotations[envoyClusterMaxRetries]; ok {
+		if v, err := strconv.Atoi(mrt); err == nil {
+			if v > 0 && v < math.MaxUint32 {
+				connectionOpts.MaxRetries = uint32(v)


nak3 · 2022-07-19T01:10:08Z

Thank you @shengyanli1982 for this PR.

I have read your draft of the release note:

The current project only use default values envoy connection parameters and are not configured for connections to clusters created by ingress. now, can configuring envoy connection parameters from ingress annotations resource by user defined.

Could you please describe what exact problems did you encounter with the current values?

shengyanli1982 · 2022-07-25T07:34:26Z

Could you please describe what exact problems did you encounter with the current values?

Of course. We used Net-Kourier + Kourier as the gateway for our backend knatvie applications. In the real world, we have a service with the concurrency mode between 10 and 60 pods. We are an e-commerce business, so the peak of requests will often be like a wave, and the enovy default of 1000 will often be stuck to our peak requests.

Our internal version has been modified and confirmed to be able to effectively support online services.

knative-prow · 2022-07-25T08:23:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shengyanli1982
To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shengyanli1982 · 2022-07-25T08:24:18Z

/retest-required

shengyanli1982 · 2022-07-25T08:25:32Z

/assign @nak3

shengyanli1982 · 2022-07-25T08:37:59Z

/retest-required

shengyanli1982 · 2022-07-25T08:46:19Z

/retest

nak3 · 2022-08-03T12:45:42Z

Thank you for the explanation and sorry for the late response.
Could you please clean up the PR? I think there are some unexpected change in the PR.

Also, if possible I would like to avoid the annotation approach. Did you consider any alternative idea to support this without the annotation?

shengyanli1982 · 2022-08-07T14:26:33Z

/skip

shengyanli1982 · 2022-08-07T14:38:09Z

emmmm. Ingress forwards traffic for a service. In this case, ingress carries the service attribute. Ingress is also a CRD resource, so these contents naturally have a clear mapping relationship. Annotation is where I can think of the most efficient way to extend custom attributes, maybe you have a better idea.

In the real world, we use Labels to distinguish different services and business types, Annotation as an application public metadata attribute definition, and Env to define variables within different versions of POD. Clear data definition layering facilitates large-scale POD operation and management.

The above content is for your reference only.

shengyanli1982 · 2022-08-07T14:38:20Z

/assign @nak3

github-actions · 2022-11-06T01:32:08Z

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

mbrancato · 2022-11-07T16:17:14Z

/remove-lifecycle stale

mbrancato · 2022-11-07T16:19:01Z

@nak3 what would be needed to get this to a state where it can be merged? If this is no longer being worked on, I could takeover this and get it to a mergable state. If you need more info on the use-case, I too have an issue linked below that this addresses.

Fixes #839

knative-prow-robot · 2023-01-14T05:52:07Z

@shengyanli1982: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

skonto · 2023-03-22T15:14:21Z

@shengyanli1982 could rebase the PR? gentle ping.

skonto · 2023-04-27T08:57:05Z

@shengyanli1982 could rebase the PR? gentle ping.

skonto · 2023-04-27T10:53:51Z

@mbrancato could you help on this one?

github-actions · 2023-07-27T01:27:49Z

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

Support for configuring envoy connection parameters in ingress, which…

d6461e4

… istio currently supports.

knative-prow bot added the kind/enhancement label Jul 11, 2022

knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2022

knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2022

knative-prow bot assigned dprotaso Jul 18, 2022

knative-prow bot assigned nak3 and unassigned dprotaso Jul 18, 2022

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2022

github-advanced-security bot found potential problems Jul 18, 2022

View reviewed changes

fix issue what is incorrect conversion between integer types

999d16e

fix some error codes in pkg/envoy/api/cluster_test.go

0f7e68f

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022

knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2022

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2023

github-actions bot closed this Aug 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for configuring envoy connection parameters in ingress, which istio currently supports. #873

Support for configuring envoy connection parameters in ingress, which istio currently supports. #873

shengyanli1982 commented Jul 11, 2022

linux-foundation-easycla bot commented Jul 11, 2022 •

edited

Loading

knative-prow bot commented Jul 11, 2022

knative-prow bot commented Jul 11, 2022

knative-prow bot commented Jul 18, 2022

shengyanli1982 commented Jul 18, 2022

shengyanli1982 commented Jul 18, 2022

knative-prow bot commented Jul 18, 2022

dprotaso commented Jul 18, 2022

dprotaso commented Jul 18, 2022

nak3 commented Jul 19, 2022

shengyanli1982 commented Jul 25, 2022

knative-prow bot commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

nak3 commented Aug 3, 2022

shengyanli1982 commented Aug 7, 2022

shengyanli1982 commented Aug 7, 2022 •

edited

Loading

shengyanli1982 commented Aug 7, 2022

github-actions bot commented Nov 6, 2022

mbrancato commented Nov 7, 2022

mbrancato commented Nov 7, 2022

knative-prow-robot commented Jan 14, 2023

skonto commented Mar 22, 2023

skonto commented Apr 27, 2023

skonto commented Apr 27, 2023

github-actions bot commented Jul 27, 2023

Support for configuring envoy connection parameters in ingress, which istio currently supports. #873

Support for configuring envoy connection parameters in ingress, which istio currently supports. #873

Conversation

shengyanli1982 commented Jul 11, 2022

Changes

linux-foundation-easycla bot commented Jul 11, 2022 • edited Loading

knative-prow bot commented Jul 11, 2022

knative-prow bot commented Jul 11, 2022

knative-prow bot commented Jul 18, 2022

shengyanli1982 commented Jul 18, 2022

shengyanli1982 commented Jul 18, 2022

knative-prow bot commented Jul 18, 2022

dprotaso commented Jul 18, 2022

dprotaso commented Jul 18, 2022

nak3 commented Jul 19, 2022

shengyanli1982 commented Jul 25, 2022

knative-prow bot commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

shengyanli1982 commented Jul 25, 2022

nak3 commented Aug 3, 2022

shengyanli1982 commented Aug 7, 2022

shengyanli1982 commented Aug 7, 2022 • edited Loading

shengyanli1982 commented Aug 7, 2022

github-actions bot commented Nov 6, 2022

mbrancato commented Nov 7, 2022

mbrancato commented Nov 7, 2022

knative-prow-robot commented Jan 14, 2023

skonto commented Mar 22, 2023

skonto commented Apr 27, 2023

skonto commented Apr 27, 2023

github-actions bot commented Jul 27, 2023

linux-foundation-easycla bot commented Jul 11, 2022 •

edited

Loading

shengyanli1982 commented Aug 7, 2022 •

edited

Loading