Bump to latest Kafka clients 3.7#3900
Merged
knative-prow[bot] merged 3 commits intoJun 6, 2024
Merged
Conversation
knative-prow
Bot
added
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3900 +/- ##
=======================================
Coverage 48.24% 48.24%
=======================================
Files 246 246
Lines 14500 14500
=======================================
Hits 6995 6995
Misses 6799 6799
Partials 706 706 ☔ View full report in Codecov by Sentry. |
pierDipi
force-pushed
the
bump-kafka-to-3.7
branch
from
May 15, 2024 17:36
79000a7 to
0acb8f5
Compare
matzew
reviewed
May 16, 2024
| logDebug("Value is null", recordContext.getRecord()); | ||
| final var value = cloudEventDeserializer.deserialize( | ||
| recordContext.getRecord().topic(), recordContext.getRecord().headers(), null); | ||
| recordContext.getRecord().topic(), recordContext.getRecord().headers(), (byte[]) null); |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
bump-kafka-to-3.7
branch
from
May 29, 2024 08:37
0acb8f5 to
6f5c8b4
Compare
Member
Author
|
/retest |
pierDipi
changed the title
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/retest |
Member
Author
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Contributor
|
/test reconciler-tests-namespaced-broker |
Contributor
|
/test upgrade-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title