Attempt to fix Julia v0.6 support #54
Conversation
| @@ -142,11 +143,20 @@ end | |||
|
|
|||
| override_info(;args...) = (:override_info, true) in args | |||
|
|
|||
| # Keyword arguments x=1 passed to macros are parsed as Expr(:(=), :x, 1) but | |||
| # must be passed as Expr(:(kw), :x, 1) in Julia v0.6. | |||
| @static if VERSION < v"0.6-" | |||
There was a problem hiding this comment.
@static probably isn't necessary here (although I doubt it hurts anything).
| @test ex |> macroexpand == :nothing | ||
| end | ||
| end | ||
| end |
|
I think this is a step in the right direction, but I probably can't release a version yet. Julia has moved more strongly to the convention that packages should not overwrite I'll try to commit some time to address this issue over the weekend. (You also might consider using Cheers! |
|
Ok, thanks! Memento.jl does look quite nice, and I've been looking at the new logging features in Base too. But my goal here was just to un-break Mocha.jl :) |
* fix keyword handling in julia v0.6 * use Compat: @static * macro hygiene fixes * ensure that macros work inside modules too
There were some changes to the way keyword arguments are parsed in Julia v0.6 that broke Logging.jl. I believe this should fix it, but I'd appreciate it if someone familiar with how the package works could try it as well (the unit tests are passing, but I don't know the expected behavior well).