Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depwarn in test #52

Merged
merged 3 commits into from
Oct 18, 2016
Merged

Fix depwarn in test #52

merged 3 commits into from
Oct 18, 2016

Conversation

ranjanan
Copy link
Contributor

symbol -> Symbol

@kmsquire
Copy link
Owner

This requires Compat to work on Julia v0.4. However, I'm about to split v0.4 and v0.5 branches. Will update here when that's done.

@ranjanan
Copy link
Contributor Author

@kmsquire are you sure? Because the Symbol constructor works on both v0.4 and v0.5 without the need to use Compat

@kmsquire
Copy link
Owner

See https://travis-ci.org/kmsquire/Logging.jl/jobs/167685951

@kmsquire kmsquire merged commit b1492b8 into kmsquire:master Oct 18, 2016
@kmsquire
Copy link
Owner

Thanks!

@ranjanan ranjanan deleted the RA/dw branch October 18, 2016 05:57
@ranjanan
Copy link
Contributor Author

@kmsquire Would you mind tagging a new release please? Thanks!

@ViralBShah
Copy link

Was a new release tagged? I got this with Pkg.test("Mocha")

WARNING: Method definition info(Any...) in module Base at util.jl:320 overwritten in module Logging at /Users/viral/.julia/v0.5/Logging/src/Logging.jl:115.
WARNING: Method definition warn(Any...) in module Base at util.jl:350 overwritten in module Logging at /Users/viral/.julia/v0.5/Logging/src/Logging.jl:115.
WARNING: Method definition warn(Any...) in module Base at util.jl:350 overwritten in module Logging at /Users/viral/.julia/v0.5/Logging/src/Logging.jl:115.
WARNING: Method definition info(Any...) in module Base at util.jl:320 overwritten in module Logging at /Users/viral/.julia/v0.5/Logging/src/Logging.jl:115

kmsquire pushed a commit that referenced this pull request Jun 2, 2017
@ranjanan @kmsquire
Fix depwarn in test (#52)
b00a42c 
* Fix `Symbol` depwarn in test
* Use `Compat` for v0.4 compatibilty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranjanan @kmsquire @ViralBShah