Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run addEventListener each draw #263

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

kmkzt
Copy link
Owner

@kmkzt kmkzt commented Jul 28, 2020

No description provided.

@kmkzt kmkzt added the enhancement Enhancement label Jul 28, 2020
@kmkzt kmkzt changed the title feat: Don't run addEventListener each time you draw Don't run addEventListener each draw Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.73%.
The diff coverage is 25.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   59.06%   59.79%   +0.73%     
==========================================
  Files          20       20              
  Lines         899      893       -6     
  Branches      168      168              
==========================================
+ Hits          531      534       +3     
+ Misses        249      240       -9     
  Partials      119      119              
Impacted Files Coverage Δ
packages/core/src/drawing.ts 49.54% <25.53%> (+5.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6fc1f...0793190. Read the comment docs.

@kmkzt kmkzt merged commit 2884b2c into master Jul 28, 2020
@kmkzt kmkzt deleted the feature/improve-drawing-listner branch July 28, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant