refactor: improve update render

kmkzt · May 17, 2020 · a3f9a01 · a3f9a01
1 parent 1bd17e4
commit a3f9a01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/renderer.ts b/src/renderer.ts
@@ -24,10 +24,10 @@ export class Renderer extends Svg {
   }
   /**
    * render
-   * TODO: improve render
+   * TODO: XSS test
    */
   public update() {
-    this.el.innerHTML = this.toElement().outerHTML
+    this.el.replaceChild(this.toElement(), this.el.childNodes[0])
   }
 
   public resize(param?: DOMRect) {

diff --git a/src/svg.ts b/src/svg.ts
@@ -200,8 +200,8 @@ export class Path {
       strokeLinejoin: this.circuler ? 'round' : 'mitter'
     }
   }
-  public toElement(): HTMLElement {
-    const path = document.createElement('path')
+  public toElement(): SVGPathElement {
+    const path = document.createElementNS('http://www.w3.org/2000/svg', 'path')
     path.setAttribute('stroke-width', String(this.strokeWidth))
     path.setAttribute('stroke', this.stroke)
     path.setAttribute('fill', this.fill)