fix: fix fromImageElement for return Promise and add comment

kmkzt · Jul 30, 2020 · 22c966b · 22c966b
1 parent 07c8540
commit 22c966b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/img-trace/src/imgloader.ts b/packages/img-trace/src/imgloader.ts
@@ -8,6 +8,9 @@ export class ImgLoader {
   constructor(options: Partial<ImgLoaderOption>) {
     this.corsenabled = options.corsenabled ?? true
   }
+
+  // TODO: improve types.
+  // if exists callback, return void. if not existed callback, return Promise<ImageData>.
   public fromUrl(
     url: string,
     callback?: (imgd: ImageData) => void
@@ -57,6 +60,8 @@ export class ImgLoader {
     }
   }
 
+  // TODO: improve types.
+  // if exists callback, return void. if not existed callback, return Promise<ImageData>.
   public fromImageElement(
     img: HTMLImageElement,
     callback?: (imgd: ImageData) => void
@@ -89,7 +94,7 @@ export class ImgLoader {
     if (callback) {
       load(callback)
     } else {
-      new Promise(load)
+      return new Promise(load)
     }
   }
 }