Use TopologicalSort for viz yaml same as resources.yaml #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordon-klotho
commented
Mar 6, 2024
| @@ -37,7 +37,7 @@ func (f *File) WriteTo(w io.Writer) (n int64, err error) { | |||
| wh.Writef("provider: %s\n", f.Provider) | |||
| wh.Write("resources:\n") | |||
|
|
|||
| resourceIds, err := construct.ReverseTopologicalSort(f.Graph) | |||
| resourceIds, err := construct.TopologicalSort(f.Graph) | |||
There was a problem hiding this comment.
This is the change that causes all the tests to change.
gordon-klotho
commented
Mar 6, 2024
| @@ -39,6 +39,9 @@ func topologicalSort[K comparable](deps map[K]map[K]graph.Edge[K], less func(K, | |||
| enqueue(vertex) | |||
| } | |||
| } | |||
| sort.Slice(queue, func(i, j int) bool { | |||
There was a problem hiding this comment.
This has no effect but improves readability by putting the sort next to where all the queuing happens.
gordon-klotho
force-pushed
the
viz_topo_order
branch
from
51fca16 to
1176900
Compare
jhsinger-klotho
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard checks