fix scenario where env vars are empty #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSeptimus-Klotho
approved these changes
Jan 13, 2023
pkg/infra/pulumi_aws/index.ts.tmpl
Outdated
| @@ -112,7 +112,7 @@ export = async () => { | |||
| {{range $unit := .ExecUnits -}} | |||
|
|
|||
| {{- if eq $unit.Type "fargate"}} | |||
| cloudLib.createEcsService("{{$unit.Name}}",{{jsonPretty $unit.Params | indent 4}} as Partial<awsx.ecs.Container>, {{- if $unit.EnvironmentVariables}} , {{jsonPretty $unit.EnvironmentVariables | indent 4}} {{end}}); | |||
| cloudLib.createEcsService("{{$unit.Name}}",{{jsonPretty $unit.Params | indent 4}} as Partial<awsx.ecs.Container>, {{- if $unit.EnvironmentVariables}} {{jsonPretty $unit.EnvironmentVariables | indent 4}} {{else}} [] {{end}}); | |||
There was a problem hiding this comment.
Seems like the library can handle the undefined fine:
generateExecUnitEnvVars(
execUnitName: string,
env_vars?: any[]
)There was a problem hiding this comment.
so you're saying, just rm the if-else altogether? let me check if that works.
There was a problem hiding this comment.
I'm saying the previous version should be fine since the , is also included in the original if statement.
There was a problem hiding this comment.
I'm saying the previous version should be fine since the
,is also included in the original if statement.
Ah, well that's not fine. The problem wasn't the lack of ,, it was that there was nothing after the comma, so the method invocation only had two args, while it expected 3. The problem wasn't the generateExecUnitEnvVars invocation, it was the createEcsService invocation.
|
gordon-klotho
approved these changes
Jan 13, 2023
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the env var was empty, the end of the method call was
, )instead of,[]).Standard checks