Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry #83

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Telemetry #83

merged 3 commits into from
Jan 13, 2023

Conversation

jhsinger-klotho
Copy link
Contributor

@jhsinger-klotho jhsinger-klotho commented Jan 13, 2023

• Does any part of it require special attention?
• Does it relate to or fix any issue? closes #46 and closes #47

can see sample here https://app.datadoghq.com/logs?query=-service%3A%28cc_compiler%20OR%20cloudviz-233a56a%20OR%20cc_api%29&cols=host%2Cservice&event=AQAAAYWrmRqTOXkp7wAAAABBWVdybVJxVEFBQ3RzeGFtMWNiX1BnQUE&index=%2A&messageDisplay=inline&stream_sort=service%2Cdesc&viz=stream&from_ts=1673619895397&to_ts=1673620795397&live=true

right now a lot of kinds dont have types. This looks really messed up in here but i promise its normal in datadog



{
--
_logLevel | info
app | test-upgrade-path
languages { |  
NodeJStrue | NodeJS | true
NodeJS | true
}
provider | aws
resource_types { |  
aws_template_data {1}exec_unit {eks1}gateway {1}infra_as_code {1}input_files {1}persist_kv {1}persist_orm {1}topology {1} | aws_template_data { |   | 1 |   | 1 | } | exec_unit { |   | eks1 | eks | 1 | } | gateway { |   | 1 |   | 1 | } | infra_as_code { |   | 1 |   | 1 | } | input_files { |   | 1 |   | 1 | } | persist_kv { |   | 1 |   | 1 | } | persist_orm { |   | 1 |   | 1 | } | topology { |   | 1 |   | 1 | }
aws_template_data { |  
1 |   | 1
  | 1
}
exec_unit { |  
eks1 | eks | 1
eks | 1
}
gateway { |  
1 |   | 1
  | 1
}
infra_as_code { |  
1 |   | 1
  | 1
}
input_files { |  
1 |   | 1
  | 1
}
persist_kv { |  
1 |   | 1
  | 1
}
persist_orm { |  
1 |   | 1
  | 1
}
topology { |  
1 |   | 1
  | 1
}
}
resources { |  
aws_template_data1exec_unit1gateway1infra_as_code1input_files1persist_kv1persist_orm1topology1 | aws_template_data | 1 | exec_unit | 1 | gateway | 1 | infra_as_code | 1 | input_files | 1 | persist_kv | 1 | persist_orm | 1 | topology | 1
aws_template_data | 1
exec_unit | 1
gateway | 1
infra_as_code | 1
input_files | 1
persist_kv | 1
persist_orm | 1
topology | 1
}
runId | 259ba75e-db0a-4d66-a382-6a798d6dcc32
service | klo_cli_v1
strict | false
validated | false
version | v0.0.0
}


Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

if _, ok := resourceCounts[res.Key().Kind]; !ok {
resourceCounts[res.Key().Kind] = make(map[string]int)
}
resourceCounts[res.Key().Kind][res.Type()] = resourceCounts[res.Key().Kind][res.Type()] + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
resourceCounts[res.Key().Kind][res.Type()] = resourceCounts[res.Key().Kind][res.Type()] + 1
resourceCounts[res.Key().Kind][res.Type()]++

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, will update before pushing

@jhsinger-klotho jhsinger-klotho merged commit f2881a5 into main Jan 13, 2023
@jhsinger-klotho jhsinger-klotho deleted the telemetry branch January 13, 2023 15:03
@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 24%
github.com/klothoplatform/klotho/pkg/core 20%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 45%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 58%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 52%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 9%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 60%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 60%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 32%
github.com/klothoplatform/klotho/pkg/validation 73%
Summary 42% (3592 / 8586)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry: Add types of capabilities Telemetry: Keep track of which language(s) are part of a compilation
2 participants