Adds multi-language support to integration test workflow #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhsinger-klotho
approved these changes
Jan 13, 2023
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
- Added step to detect language from sample app directory prefix - Added conditions for TypeScript-specific steps - Added integ test step for python
Adds py-microservices sample app - Added py-microservices sample app - Added integration tests for py-microservices
DavidSeptimus
force-pushed
the
python-integ-tests
branch
from
20d3315 to
ced3869
Compare
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
DavidSeptimus
had a problem deploying
to
integ_test
GitHub Actions
Failure
ghost
approved these changes
Jan 13, 2023
| @@ -69,7 +69,13 @@ jobs: | |||
| set -x | |||
| dirs_with_tests="$( | |||
| for d in $(find * -type d -maxdepth 0 || printf ''); do | |||
| jq &>/dev/null -e '.scripts."integ-test"' $d/package.json && echo "$d" | |||
| TESTABLE_APP=$(jq &>/dev/null -e '.scripts."integ-test"' $d/package.json && echo "$d") | |||
| if [[ ! -z $(grep "^integ-test:" "${d}/Makefile" 2> /dev/null) ]]; then | |||
There was a problem hiding this comment.
Super minor, but in case you're interested:
! -zis aka-n- you can just do
if grep -q ... ; then(with no[[ ... ]]]). In that mode,grepdoesn't actually output anything (to either stdout or stderr), but instead just exits with 0 iff any lines matched
There was a problem hiding this comment.
thanks. I used -s instead of -q to avoid printing File not found for Makefile in typescript projects.
| @@ -166,6 +175,7 @@ jobs: | |||
| env: | |||
| KLOTHO_LOGIN: ${{ inputs.klotho-login }} | |||
| - name: typescript compilation | |||
| if: steps.get_language.outputs.language == 'ts' | |||
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
DavidSeptimus
temporarily deployed
to
integ_test
GitHub Actions
Inactive
ghost
approved these changes
Jan 13, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple languages (specifically including Python) through the following means:
Makefilecontaining aninteg-testruleStandard checks