replace fs implementation with v3 client #70
Conversation
| }) | ||
|
|
||
| async function getCallParameters(paramKey, dispatcherMode) { | ||
| let isEmitter = dispatcherMode === 'emitter' ? true : false |
There was a problem hiding this comment.
nit:
| let isEmitter = dispatcherMode === 'emitter' ? true : false | |
| let isEmitter = dispatcherMode === 'emitter' |
| if (isEmitter && Array.isArray(parameters)) { | ||
| // Emitters only have 1 parameter - the runtime saves an array, so we | ||
| // normalize the parameter | ||
| parameters = _.get(parameters, '[0]') |
There was a problem hiding this comment.
How is this different from just parameters[0]? I tested, and it looks like parameters[0] evaluates to undefined if the array is empty, so we don't need index-bounds protection.
There was a problem hiding this comment.
a lot of this was copy paste from the old implementation, going to try to remove some of the more odd things like this
| if (Array.isArray(parameters)) { | ||
| let paramPairs = _.toPairs(parameters) | ||
| paramPairs = paramPairs.map((x) => { | ||
| if (_.get(x, '[1].type') == 'Buffer') { |
There was a problem hiding this comment.
similarly, if this is for index bounds, I think typescript can do it as just if (x[1]?.type == 'Buffer')
|
|
||
| return parameters || {} | ||
| } catch (e) { | ||
| console.error(e) |
There was a problem hiding this comment.
Why don't we want to rethrow? (Ditto for similar lines below)
There was a problem hiding this comment.
good call, we should ill add that in, was my miss
| } | ||
| try { | ||
| await s3Client.send(new PutObjectCommand(bucketParams)) | ||
| console.log('Successfully uploaded object: ' + bucketParams.Bucket + '/' + bucketParams.Key) |
There was a problem hiding this comment.
I wonder if this should be debug? I'd be worried about spamming the service logs with what is essentially an implementation detail (they should be able to assume that if the s3 didn't log a failure, that it succeeded).
Similar for other log lines, other than the ones within catches.
There was a problem hiding this comment.
hm, yeah i can add them all as debug
| if (Array.isArray(parameters)) { | ||
| let paramPairs = _.toPairs(parameters) | ||
| paramPairs = paramPairs.map((x) => { | ||
| if (x[1].type == 'Buffer') { |
There was a problem hiding this comment.
| if (x[1].type == 'Buffer') { | |
| if (x[1] instanceof Buffer) { |
| let paramPairs = _.toPairs(parameters) | ||
| paramPairs = paramPairs.map((x) => { | ||
| if (x[1].type == 'Buffer') { | ||
| return [x[0], Buffer.from(x[1].data)] |
There was a problem hiding this comment.
Is this supposed to be a clone then? It's already a buffer, so this just reads it into another buffer, right?
There was a problem hiding this comment.
looks like it, i can just change it to return x[1].data
| // normalize the parameter | ||
| parameters = parameters[0] | ||
| if (Array.isArray(parameters)) { | ||
| let paramPairs = _.toPairs(parameters) |
There was a problem hiding this comment.
Object.entries I believe is the equivalent to toPairs
|
• Does any part of it require special attention?
• Does it relate to or fix any issue? closes https://github.com/klothoplatform/klotho-history/issues/528
Changing the fs implementation in node so we dont use the large aws sdk. also added delete object as unlink
Tested by using the cloudfs sample app and running integration tests
Standard checks