move most of integtest into a callable workflow #45
Conversation
Rather than integtest.yaml containing all of the integ test logic, it now just invokes a new workflow, which contains all of its old logic. This makes it possible to invoke the tests from other repos. It seems silly to create a workflow that does nothing but call another workflow, but I _think_ that's necessary because during a cron-triggered run, the `inputs.*` object is empty (not populated with the default values). It's also silly and a bit brittle to have the workflow_dispatch and workflow_call sections duplicate the same inputs, but unfortunately that seems to be what GH Actions require. As part of this, rename integtest.yaml to nightly-integ-tests.yaml. This will kill the existing workflow history, but there's not much of it right now anyway.
See klothoplatform/klotho-history#259
| @@ -84,14 +125,20 @@ jobs: | |||
| app_to_test: ${{ fromJson(needs.list-apps.outputs.to_test) }} | |||
| mode: [fresh, upgrade] | |||
| exclude: | |||
| - # issue $618 | |||
| - # issue #618 | |||
There was a problem hiding this comment.
nit: These reference tickets on the old repo.
There was a problem hiding this comment.
yeah, I wasn't really sure what to do with these in general. Should I refer to it as klotho-history#618? Do we want to advertise that in-the-code-ly the existence of that repo?
We can't move issues from a private repo to a public one (I tried), or else I'd have just moved it over as part of this.
There was a problem hiding this comment.
Probably have to just move them the old fashioned way - good 'ol C-c C-v 😄
| @@ -188,7 +240,7 @@ jobs: | |||
| PULUMI_CONFIG_PASSPHRASE: "" | |||
| - name: pulumi up (upgrade path) | |||
| if: matrix.mode == 'upgrade' | |||
| uses: klothoplatform/gh-action-retry@v1 | |||
| uses: CloudCompilers/gh-action-retry@v1 | |||
There was a problem hiding this comment.
Does the new org name not work with this?
There was a problem hiding this comment.
Whoops, yes it would/should. I missed this, thanks!
Sorry about that! It lets us invoke these integ tests from another workflow, and specifically it'll let us invoke them (but with a different sample-apps repo) from the klotho-pro repo. That means that we won't have to maintain two copies of that big integtest.yaml file: we'll have just this one, and then each repo (klotho and klotho-pro) can invoke it to run its respective tests. |
You mean like using a |
Yup, exactly. The pro repo will have a trivial workflow almost identical to this PR's nightly-integ-tests.yaml |
|
ghost
merged commit 
ghost
mentioned this pull request
Rather than integtest.yaml containing all of the integ test logic, it now just invokes a new workflow, which contains all of its old logic. This makes it possible to invoke the tests from other repos.
It seems silly to create a workflow that does nothing but call another workflow, but I think that's necessary because during a cron-triggered run, the
inputs.*object is empty (not populated with the default values).It's also silly and a bit brittle to have the workflow_dispatch and workflow_call sections duplicate the same inputs, but unfortunately that seems to be what GH Actions require.
As part of this, rename integtest.yaml to nightly-integ-tests.yaml. This will kill the existing workflow history, but there's not much of it right now anyway.
Standard checks