make fileref use root path and stat unit have same logic as embed #34
Conversation
| @@ -98,6 +105,45 @@ type staticAssetPathMatcher struct { | |||
| err error | |||
| } | |||
|
|
|||
| func (m *staticAssetPathMatcher) ModifyPathsForAnnotatedFile(path string) error { | |||
There was a problem hiding this comment.
Can you doc a bit what this function does? I'm getting lost in the "Abs", "Rel" etc. It likely is similar to how readdir works, but I've forgotten how that works 😄
| var f core.File = &core.FileRef{FPath: relPath} | ||
| var f core.File = &core.FileRef{ | ||
| FPath: relPath, | ||
| RootConfigPath: cfg.Path, |
There was a problem hiding this comment.
One thing to be mindful of here is that this path is relative to the "root", which is split from the original passed-in path in splitPathRoot. This is to prevent plugins from accessing arbitrary files (eg, FPath: "../../../etc/passwd").
There was a problem hiding this comment.
when do we allow access to files outside of the root of the klotho run? Im failing to understand this a little bit so do you have a scenario?
There was a problem hiding this comment.
This was more a defense against mistakes and third-party plugins (when we get them). Might not be necessary for now, but it does mean this could be incorrect - try doing klotho ../ --app blah
There was a problem hiding this comment.
makes sense, let me make a note of that and run through that scenario, if it doesnt work, ill cut a card to fix it
|
| if err != nil { | ||
| return err | ||
| } | ||
| if absPath == pattern { |
There was a problem hiding this comment.
im not quite understanding why this is a special case. Won't every absPath have a /? Why is the prefix only trimmed if the filpath.Abs(pattern) seemingly does nothing to the path?
There was a problem hiding this comment.
so our paths for files are like src/somefile.txt
if they specify an absolute path of /src/somefile.txt we wont match unless we remove the prefix /
The other scenario after that is for relative paths, which wont start with / anyways.
The only real reason we check absPath == pattern is just to make sure its a true absolute path.
If that doesnt make sense we can rework this or have another discussion, going to push to get the search the deck stuff going for ala
* Cleans up error handling in the up command * Returns an error if the "Name" input is supplied * Clarifies default region error * Adds utilities for some frequent reflection operations
• Does any part of it require special attention?
• Does it relate to or fix any issue?
Since file ref needs to read the actual code from the file we need to supply it with the path from our config to join to the file path.
Also changing static unit to match files based on relative path and absolute path to close #33
This is all work for the search the deck changes
Standard checks