Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the log group for the lambda function #301

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

jhsinger-klotho
Copy link
Contributor

• Does any part of it require special attention?
• Does it relate to or fix any issue?

a user reported this as an orphaned log group and its due to the fact that lambda logs to a specific log group naming format. Due to sanitization that format changed. Here we should not sanitize the log group because if the lambda name is valid, so is the log group

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@gordon-klotho
Copy link
Contributor

Might be worth dropping that (that the format is an AWS thing) in a comment.

@jhsinger-klotho jhsinger-klotho merged commit 5985acf into main Mar 1, 2023
@jhsinger-klotho jhsinger-klotho deleted the log_group branch March 1, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants