New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner for update in progress #294

Merged

gordon-klotho merged 3 commits into main from feature/update_spinner

Feb 28, 2023

Contributor

gordon-klotho commented Feb 28, 2023

The server doesn't return Content-Length header so it just gives a spinner instead of a progress bar.

Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

gordon-klotho added 3 commits

February 28, 2023 10:29


          Add spinner for update in progress

1d4a594


          Use package's reader instead of own tee reader

f0a706f


          Add comment for why using NoColor

3a1d94e

jhsinger-klotho approved these changes

View reviewed changes

gordon-klotho merged commit 1d4951c into main

gordon-klotho deleted the feature/update_spinner branch

February 28, 2023 16:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet