New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use NewClient and add universalProperties to expectation #291

Merged

gordon-klotho merged 1 commit into main from internal/no_login_tests

Feb 28, 2023

Contributor

gordon-klotho commented Feb 27, 2023

This fixes the tests relying on the runner being logged in.

Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?


          Don't use NewClient and add universalProperties to expectation

698e187

jhsinger-klotho approved these changes

View reviewed changes

gordon-klotho merged commit 191ecb2 into main

gordon-klotho deleted the internal/no_login_tests branch

February 28, 2023 00:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet