Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #289

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Replace deprecated command with environment file #289

merged 1 commit into from
Feb 27, 2023

Conversation

jongwooo
Copy link
Contributor

Description

Resolve #288

Update .github/workflows/release.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo ::set-output name=VERSION::$(echo $GITHUB_REF | cut -d / -f 3)

TO-BE

run: echo VERSION=$(echo $GITHUB_REF | cut -d / -f 3) >> $GITHUB_OUTPUT

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2023

CLA assistant check
All committers have signed the CLA.

@gordon-klotho
Copy link
Contributor

Thanks for the update, glad to know our releases won't be broken come June 1st.

@gordon-klotho gordon-klotho merged commit a76f829 into klothoplatform:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants