improve auth analytics #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always get a LoginInfo from the authorizer; this is never nil, and always contains an "Authorizer" field which should be a non-empty string describing the authorizer (for now, just "auth0" or "local"). Then, always attach that info to the analytics. This will let us know e.g. how many compiles are using local vs auth0. This resolves #218
pkg/cli/klothomain.go
Outdated
| @@ -37,11 +37,11 @@ type KlothoMain struct { | |||
| } | |||
| type Authorizer interface { | |||
|
|
|||
| // Authorize tries to authorize the user. The KlothoClaims it returns may be nil, even if the authentication | |||
| // succeeds. Conversely, if the KlothoClaims is non-nil, it is valid even if the error is also non-nil; you can use | |||
| // Authorize tries to authorize the user. The klothoClaims it returns may be nil, even if the authentication | |||
There was a problem hiding this comment.
Suggested change
| // Authorize tries to authorize the user. The klothoClaims it returns may be nil, even if the authentication | |
| // Authorize tries to authorize the user. The `LoginInfo` it returns may be nil, even if the authentication |
gordon-klotho
approved these changes
Feb 24, 2023
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always get a LoginInfo from the authorizer; this is never nil, and always contains an "Authorizer" field which should be a non-empty string describing the authorizer (for now, just "auth0" or "local"). Then, always attach that info to the analytics. This will let us know e.g. how many compiles are using local vs auth0.
This resolves #218
Standard checks