Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config secret resources to iac and modularize #243

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Conversation

jhsinger-klotho
Copy link
Contributor

• Does any part of it require special attention?
• Does it relate to or fix any issue?

this is a follow up to #242

In this pr we add the new term SecretsManagerSecrets to our aws template and we take the name and the path for the file which contains the value.

For our current secrets, since the secret name is the path we set that for the values file. For config resources right now we leave it empty.

For config resources since we see theres no values file we prompt for the path in pulumi config to create it.

This modularizes the secrets manager iac code so we optionally add it to output and just construct the class

Standard checks

  • Unit tests: Any special considerations? its all iac so none added, integ tests will have to be the method
  • Docs: Do we need to update any docs, internal or public? When we release klotho::config yes, but not yet
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? yeah it should be the code for the current persist secrets path should not have changed

Base automatically changed from config_cap to main February 21, 2023 16:16
@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 3%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 72%
github.com/klothoplatform/klotho/pkg/lang 38%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 36%
github.com/klothoplatform/klotho/pkg/lang/javascript 48%
github.com/klothoplatform/klotho/pkg/lang/python 61%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 6%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 58%
github.com/klothoplatform/klotho/pkg/runtime 78%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/updater 30%
github.com/klothoplatform/klotho/pkg/validation 74%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 42% (4132 / 9861)

@jhsinger-klotho jhsinger-klotho merged commit a84fed9 into main Feb 21, 2023
@jhsinger-klotho jhsinger-klotho deleted the config_iac branch February 21, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants