Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use connectionId in triggers for new gateway deployment #208

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

gordon-klotho
Copy link
Contributor

Should hopefully fix #202

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

parent: api,
replaceOnChanges: ['*'],
deleteBeforeReplace: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause downtime, which could be ok if we are accepting that, but we will always have periods of BAD GATEWAY responses in this scenario

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already do this for API Gateways here: https://github.com/klothoplatform/klotho/pull/208/files#diff-86a7f02a80cba7c191b1ed596a10dcceb360abb88a53be60c32bd9a195480d41R321-R344

We may want to fix it for this case too, but let's at least fix the tests then prioritize the downtime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that link takes me right to the addition of these lines so a little confused where its. supposed to take me to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, yeah i mean if this works then good enough for now, but we likely want to figure out a good way to solve this moving forward because it would be bad for a production env

@@ -372,6 +371,8 @@ export class ApiGateway {
},
{
parent: method,
replaceOnChanges: ['*'],
deleteBeforeReplace: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here about downtime.

@jhsinger-klotho
Copy link
Contributor

can we run some of the upgrade tests to verify? The downtime may be acceptable because this should not be happening often but maybe a wider discussion

@gordon-klotho gordon-klotho temporarily deployed to integ_test February 6, 2023 21:58 — with GitHub Actions Inactive
@gordon-klotho gordon-klotho temporarily deployed to integ_test February 7, 2023 02:32 — with GitHub Actions Inactive
Comment on lines 163 to 166
// Vary the description to force recreation if the vpcLink changes
// https://github.com/hashicorp/terraform/issues/6613#issuecomment-322264393
// https://github.com/hashicorp/terraform/issues/18392#issuecomment-402684841
description: pulumi.interpolate`Stage hash: ${sha256.sync(vpcLink.id)}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for v2API, the restAPI we use is v1, which is just in the create Docker Lambda function

@gordon-klotho gordon-klotho changed the title Use replaceOnChanges for gateway resources using vpclink Use connectionId in triggers for new gateway deployment Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 38%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 19%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 61%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 59%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 40% (3793 / 9417)

@gordon-klotho gordon-klotho merged commit 454f663 into main Feb 7, 2023
@gordon-klotho gordon-klotho deleted the bugfix/vpclink_order branch February 7, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPCLinks cannot be replaced
2 participants