change metadata name to force replacement

[jhsinger-klotho]

• Does any part of it require special attention?
• Does it relate to or fix any issue? fixes upgrade path for eks tests

since sanitiztion modiied target group names and thus arns, we need to trigger a new TGB to be created since you cant replace arns in an existing TGB.

error from integ tests

    kubernetes:elbv2.k8s.aws/v1beta1:TargetGroupBinding (main-tgb):
      error: 1 error occurred:
      	* the Kubernetes API server reported that "default/main-tgb" failed to fully initialize or become live: admission webhook "vtargetgroupbinding.elbv2.k8s.aws" denied the request: TargetGroupBinding update may not change these fields: spec.targetGroupARN

Standard checks

• Unit tests: Any special considerations?
• Docs: Do we need to update any docs, internal or public?
• Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

[github-actions]

Package	Line Rate	Health
github.com/klothoplatform/klotho/pkg/analytics	2%	❌
github.com/klothoplatform/klotho/pkg/annotation	23%	❌
github.com/klothoplatform/klotho/pkg/cli	4%	❌
github.com/klothoplatform/klotho/pkg/core	21%	❌
github.com/klothoplatform/klotho/pkg/env_var	82%	✔
github.com/klothoplatform/klotho/pkg/exec_unit	53%	➖
github.com/klothoplatform/klotho/pkg/infra/kubernetes	59%	➖
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm	39%	❌
github.com/klothoplatform/klotho/pkg/input	63%	➖
github.com/klothoplatform/klotho/pkg/lang	38%	❌
github.com/klothoplatform/klotho/pkg/lang/dockerfile	0%	❌
github.com/klothoplatform/klotho/pkg/lang/golang	19%	❌
github.com/klothoplatform/klotho/pkg/lang/javascript	47%	❌
github.com/klothoplatform/klotho/pkg/lang/python	60%	➖
github.com/klothoplatform/klotho/pkg/lang/yaml	0%	❌
github.com/klothoplatform/klotho/pkg/logging	7%	❌
github.com/klothoplatform/klotho/pkg/multierr	95%	✔
github.com/klothoplatform/klotho/pkg/provider/aws	59%	➖
github.com/klothoplatform/klotho/pkg/runtime	75%	✔
github.com/klothoplatform/klotho/pkg/static_unit	33%	❌
github.com/klothoplatform/klotho/pkg/validation	73%	➖
github.com/klothoplatform/klotho/pkg/yaml_util	79%	✔
Summary	40% (3793 / 9454)	❌

[gordon-klotho]

I think there's pulumi-meta things you can do to let it know what things might trigger a replacement (hash or something?) but this is easy and makes sense to me.

[jhsinger-klotho]

I think there's pulumi-meta things you can do to let it know what things might trigger a replacement (hash or something?) but this is easy and makes sense to me.

yeah i could have done delete before replace, but i didnt want that in there permanently because if the port changes we dont want to force downtime by replacing the TGB