-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change annotations to be a map with pointer values #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you explain the reasoning for this change? Just trying to understand whats going on and the benefits of it |
gordon-klotho
force-pushed
the
internal/source_file
branch
from
January 6, 2023 16:29
88cb96e
to
aafed48
Compare
ghost
approved these changes
Jan 6, 2023
ghost
reviewed
Jan 6, 2023
Additionally, on reparse the annotation values are updated instead of replaced leaving the pointer values still valid
gordon-klotho
force-pushed
the
internal/source_file
branch
from
January 10, 2023 16:52
6b1ff6c
to
ec2c865
Compare
|
ghost
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable us to do less "hacky" things when modifying source code - not having to worry about keeping a separate "newContent" then only calling reparse once at the end.
Standard checks