Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payloads bucket name cant be sanitized #189

Merged
merged 2 commits into from
Feb 3, 2023
Merged

payloads bucket name cant be sanitized #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0ce09
payloads bucket name cant be sanitized
Feb 3, 2023
a7b3508
update comment
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pkg/infra/pulumi_aws/deploylib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,8 @@ export class CloudCCLib {
if (this.createVPC) {
this.getVpcSgSubnets()
}
const resolvedBucketName = this.account.accountId.apply(
(accountId) =>
sanitized(
AwsSanitizer.S3.bucket.nameValidation()
)`${accountId}${physicalPayloadsBucketName}`
)
// Right now we sanitize this bucket name in the compiler go code so we do not need to here (issue #188 & pro#51)
const resolvedBucketName = pulumi.interpolate`${this.account.accountId}${physicalPayloadsBucketName}`
this.createBuckets([resolvedBucketName], true)
this.addSharedPolicyStatement({
Effect: 'Allow',
Expand Down