Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass lb plugin back to eks plugin #185

Merged
merged 3 commits into from
Feb 3, 2023
Merged

pass lb plugin back to eks plugin #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fae16c1
pass lb plugin back to eks plugin
Feb 3, 2023
5f49ef4
remove upgrade for env var tests
Feb 3, 2023
7824fd1
add issue comment
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/run-integ-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@ jobs:
matrix:
app_to_test: ${{ fromJson(needs.list-apps.outputs.to_test) }}
mode: [fresh, upgrade]
exclude:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file issues for the ignored tests (or just one, if they're the same problem) and add a reference to it as comments to the ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup will do

- # issue #186
app_to_test: ts-orm-environment-variable-directive
mode: upgrade
- # issue #186
app_to_test: ts-redis-env-var-directive
mode: upgrade
steps:
- name: versions
run: |
Expand Down
3 changes: 2 additions & 1 deletion pkg/infra/pulumi_aws/deploylib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,8 @@ export class CloudCCLib {
this,
execUnits,
charts || [],
existingCluster
existingCluster,
lbPlugin
)
}

Expand Down