Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

conditionally create load balancers for ecs #167

Merged
merged 2 commits into from
Jan 31, 2023
Merged

conditionally create load balancers for ecs #167

merged 2 commits into from
Jan 31, 2023

Conversation

jhsinger-klotho
Copy link
Contributor

• Does any part of it require special attention?
• Does it relate to or fix any issue?

now that topology has the type of expose, we can conditionally create these nlbs and support albs as well

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 20%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 61%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 59%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 40% (3799 / 9453)

this.topology.topologyIconData.forEach((resource) => {
if (resource.kind === Resource.gateway) {
this.topology.topologyEdgeData.forEach((edge) => {
if (edge.source == resource.id && edge.target === `${execUnitName}_exec_unit`) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, unless this is intentional (in which case I'd ask for a comment):

Suggested change
if (edge.source == resource.id && edge.target === `${execUnitName}_exec_unit`) {
if (edge.source === resource.id && edge.target === `${execUnitName}_exec_unit`) {

Comment on lines +1446 to 1447
nlb != undefined
? nlb.listeners
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: If you wanted, I think you could just do this as nlb?.listeners ?? [ { containerPort ... } ]

@jhsinger-klotho jhsinger-klotho merged commit 5efec25 into main Jan 31, 2023
@jhsinger-klotho jhsinger-klotho deleted the ecs_lb branch January 31, 2023 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants