Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# support foundations #161

Merged
merged 2 commits into from
Jan 31, 2023
Merged

C# support foundations #161

merged 2 commits into from
Jan 31, 2023

Conversation

gordon-klotho
Copy link
Contributor

Resolves #158 to prepare for execution unit and expose implementation.

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

@gordon-klotho gordon-klotho changed the title Feature/cs common C# support foundations Jan 31, 2023
@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2% ❌
github.com/klothoplatform/klotho/pkg/annotation 23% ❌
github.com/klothoplatform/klotho/pkg/cli 4% ❌
github.com/klothoplatform/klotho/pkg/core 20% ❌
github.com/klothoplatform/klotho/pkg/env_var 82% ✔
github.com/klothoplatform/klotho/pkg/exec_unit 54% ➖
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59% ➖
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39% ❌
github.com/klothoplatform/klotho/pkg/input 63% ➖
github.com/klothoplatform/klotho/pkg/lang 37% ❌
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0% ❌
github.com/klothoplatform/klotho/pkg/lang/golang 19% ❌
github.com/klothoplatform/klotho/pkg/lang/javascript 47% ❌
github.com/klothoplatform/klotho/pkg/lang/python 60% ➖
github.com/klothoplatform/klotho/pkg/lang/yaml 0% ❌
github.com/klothoplatform/klotho/pkg/logging 7% ❌
github.com/klothoplatform/klotho/pkg/multierr 95% ✔
github.com/klothoplatform/klotho/pkg/provider/aws 59% ➖
github.com/klothoplatform/klotho/pkg/runtime 75% ✔
github.com/klothoplatform/klotho/pkg/static_unit 32% ❌
github.com/klothoplatform/klotho/pkg/validation 73% ➖
github.com/klothoplatform/klotho/pkg/yaml_util 79% ✔
Summary 40% (3801 / 9520) ❌

DavidSeptimus-Klotho
DavidSeptimus-Klotho approved these changes Jan 31, 2023
View reviewed changes
pkg/input/readdir.go
csLang := &languageFiles{
name: CSharp,
// TODO: Since C# projects don't have a specific named project file, we'll need to update how looking for the project file works.
packageFileName: fmt.Sprintf("%s.csproj", cfg.AppName),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this definitely needs a better implementation.

@gordon-klotho gordon-klotho merged commit bb48397 into main Jan 31, 2023
@gordon-klotho gordon-klotho deleted the feature/cs_common branch January 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidSeptimus-Klotho DavidSeptimus-Klotho DavidSeptimus-Klotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C# parsing and common functions
2 participants
@gordon-klotho @DavidSeptimus-Klotho