Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow list of helm values to be passed in #123

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

jhsinger-klotho
Copy link
Contributor

@jhsinger-klotho jhsinger-klotho commented Jan 22, 2023

• Does any part of it require special attention?
• Does it relate to or fix any issue? closes #75

this is a breaking change, but i dont think anyone outside of komodor is using helm functionality and we will walk them through it.

Allows a list of values file paths to be passed in rather than singular path.

Standard checks

  • Unit tests: Any special considerations? updated
  • Docs: Do we need to update any docs, internal or public? https://github.com/klothoplatform/docs/pull/153
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? no, the config of valuesFile changed to valuesFiles

@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 20%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 45%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 9%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 60%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 60%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 32%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 40% (3694 / 9342)

@jhsinger-klotho jhsinger-klotho merged commit 98d5e59 into main Jan 23, 2023
@jhsinger-klotho jhsinger-klotho deleted the helm_values_list branch January 23, 2023 19:09
atorres-klo added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow list of values files for helm
2 participants