make sure no resource has the same id for capability type #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhsinger-klotho
force-pushed
the
validate_resource_ids
branch
from
b486437
to
a2b4762
Compare
pkg/validation/validation.go
Outdated
| unitIds := make(map[string]struct{}) | ||
| units := core.GetResourcesOfType[T](result) | ||
| for _, unit := range units { | ||
| fmt.Println(unit) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(unit) |
pkg/validation/validation.go
Outdated
| for _, unit := range units { | ||
| fmt.Println(unit) | ||
| if id, ok := unitIds[unit.Key().Name]; ok { | ||
| return fmt.Errorf("Multiple Persist objects with the same name, '%s'", id) |
There was a problem hiding this comment.
Won't id be a struct{}{}?
There was a problem hiding this comment.
ah yeah, meant to swithc that and log name. will update
|
|
fyi, this works, i needed to rebase from main locally because the bug from a couple days ago was still affecting this finding the persist annotations to begin with |
ewucc
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Does any part of it require special attention?
• Does it relate to or fix any issue? closes #635
For now this only really will ever catch persist since no other resource type has multiple kinds, but checking them anyways in case they ever do.
Standard checks